You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/01/02 10:47:33 UTC

[GitHub] rymanluk commented on a change in pull request #699: Sensors/BMA2XX - New PR based on PR #697 changes

rymanluk commented on a change in pull request #699: Sensors/BMA2XX - New PR based on PR #697 changes
URL: https://github.com/apache/mynewt-core/pull/699#discussion_r159186048
 
 

 ##########
 File path: hw/bsp/bmd300eval/src/hal_bsp.c
 ##########
 @@ -192,8 +192,8 @@ hal_bsp_init(void)
 #endif
 
 #if MYNEWT_VAL(I2C_0)
-rc = hal_i2c_init(0, (void *)&hal_i2c_cfg);
-assert(rc == 0);
+    rc = hal_i2c_init(0, (void *)&hal_i2c_cfg);
 
 Review comment:
   According to  https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md  we should use 4 spaces instead of tabs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services