You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/22 10:09:39 UTC
[GitHub] [ozone] rakeshadr opened a new pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
rakeshadr opened a new pull request #2174:
URL: https://github.com/apache/ozone/pull/2174
## What changes were proposed in this pull request?
Rename V1 postfixes to appropriate feature name "`FSOB`" - `FileSystemOptimizedBucket`.
Note: The changes are quite large due to the large amount of keyword renaming "V1" to "FSOB" but its trivial.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5106
## How was this patch tested?
Existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr merged pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr merged pull request #2174:
URL: https://github.com/apache/ozone/pull/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#discussion_r618506327
##########
File path: hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/codec/OmKeyInfoCodec.java
##########
@@ -34,7 +34,7 @@
* Codec to encode OmKeyInfo as byte array.
*
* <p>
- * If the layout version "ozone.om.layout.version" is V1 and
+ * If the layout version "ozone.om.layout.version" is PREFIX and
Review comment:
Is this `ozone.om.metadata.layout` or `ozone.om.layout.version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#issuecomment-825391413
Thanks @ayushtkn, @mukul1987 for the reviews. I've merged it to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr edited a comment on pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr edited a comment on pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#issuecomment-824713791
**Note**: The changes are quite large due to the large amount of keyword renaming "V1" to "FSOB" but its trivial. Please excuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#issuecomment-824977270
> There are couple of changes in variable names as well, like `omResponse` -> `omResp`, `omRequest` -> `omReq`, `isDirectory` -> `isDir`. I think they were intentional.
>
> Changes LGTM.
Yes, I made those changes intentionally to reduce the statement length. I think, these var names are still readable :-)
Thanks @ayushtkn for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#issuecomment-824713791
**Note**: The changes are quite large due to the large amount of keyword renaming "V1" to "FSOB" but its trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a change in pull request #2174: HDDS-5106. [FSO] Avoid using V1 postfixes for prefix related classes
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #2174:
URL: https://github.com/apache/ozone/pull/2174#discussion_r618540785
##########
File path: hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/codec/OmKeyInfoCodec.java
##########
@@ -34,7 +34,7 @@
* Codec to encode OmKeyInfo as byte array.
*
* <p>
- * If the layout version "ozone.om.layout.version" is V1 and
+ * If the layout version "ozone.om.layout.version" is PREFIX and
Review comment:
@ayushtkn Thanks for pointing out this. Its `ozone.om.metadata.layout` , I will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org