You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/12/05 12:49:01 UTC

Review Request 71881: Allowed specifying path separator in a `path::join` overload.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71881/
-----------------------------------------------------------

Review request for mesos and Benno Evers.


Bugs: MESOS-10062
    https://issues.apache.org/jira/browse/MESOS-10062


Repository: mesos


Description
-------

Allowed specifying path separator in a `path::join` overload.


Diffs
-----

  3rdparty/stout/include/stout/path.hpp ba1f665ce94b9636d88a7ecce8643c56758f7b5c 


Diff: https://reviews.apache.org/r/71881/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 71881: Allowed specifying path separator in a `path::join` overload.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71881/#review218975
-----------------------------------------------------------


Ship it!




Ship It!

- Benno Evers


On Dec. 5, 2019, 12:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71881/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2019, 12:49 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
>     https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed specifying path separator in a `path::join` overload.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
> 
> 
> Diff: https://reviews.apache.org/r/71881/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>