You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/19 16:07:59 UTC
[GitHub] [skywalking] huangyoje opened a new pull request #4544: fix
finagle: process NoopSpan
huangyoje opened a new pull request #4544: fix finagle: process NoopSpan
URL: https://github.com/apache/skywalking/pull/4544
1. fix finagle: process NoopSpan
2. fix KafkaProducer CallbackInterceptor npe
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
1. For finagle plugin, there is a type conversion from `AbstractSpan` to `ExitSpan` in the client side, however, the `AbstractSpan` maybe a `NoopSpan`.
2. For KafkaProducer, the first parameter of `Callback#onCompletion(RecordMetadata metadata, Exception exception)` maybe null if an error occurred during processing of record.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4544: fix finagle:
process NoopSpan
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4544: fix finagle: process NoopSpan
URL: https://github.com/apache/skywalking/pull/4544#issuecomment-601487210
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=h1) Report
> Merging [#4544](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c7529a5592ca6efcfce0f0c813c1e25656a415e&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `71.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4544 +/- ##
==========================================
- Coverage 25.56% 25.53% -0.03%
==========================================
Files 1244 1245 +1
Lines 28950 28961 +11
Branches 3968 3973 +5
==========================================
- Hits 7400 7395 -5
- Misses 20866 20876 +10
- Partials 684 690 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...plugin/finagle/ServerTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9TZXJ2ZXJUcmFjaW5nRmlsdGVySW50ZXJjZXB0b3IuamF2YQ==) | `88.46% <0.00%> (ø)` | |
| [...ywalking/apm/plugin/kafka/CallbackInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4va2Fma2EtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4va2Fma2EvQ2FsbGJhY2tJbnRlcmNlcHRvci5qYXZh) | `68.00% <50.00%> (-2.84%)` | :arrow_down: |
| [...ache/skywalking/apm/plugin/finagle/CodecUtils.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db2RlY1V0aWxzLmphdmE=) | `80.70% <70.58%> (-11.14%)` | :arrow_down: |
| [...lking/apm/plugin/finagle/ContextCarrierHelper.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db250ZXh0Q2FycmllckhlbHBlci5qYXZh) | `78.57% <76.92%> (-6.05%)` | :arrow_down: |
| [...king/apm/plugin/finagle/AnnotationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Bbm5vdGF0aW9uSW50ZXJjZXB0b3IuamF2YQ==) | `77.77% <100.00%> (ø)` | |
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `57.89% <100.00%> (ø)` | |
| [...pache/skywalking/apm/plugin/finagle/Constants.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db25zdGFudHMuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4544/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=footer). Last update [1c7529a...580acd1](https://codecov.io/gh/apache/skywalking/pull/4544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4544: fix finagle:
process NoopSpan
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4544: fix finagle: process NoopSpan
URL: https://github.com/apache/skywalking/pull/4544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services