[GitHub] [maven] gnodet commented on pull request #616: [MNG-7160] Fix core extension classloader

[GitBox <gi...@apache.org>]

gnodet commented on pull request #616:
URL: https://github.com/apache/maven/pull/616#issuecomment-975860391


   > To me this change looks kinda okay, but also not okay, here is why:
   > 
   > * before change it was delegated, but as core extension realm has no imports applied to it (!), it really has no effect is it "base" realm (parent classload in java lingo) or "parent" realm.
   
   Not really, when no imports are specified for the parent realm, the realm has full visibility on its parent.
   
   > * but `CoreExports` (and corresponding XML file) seems was never applied/used in core extension realm?
   
   The xml extension is not used, that's right.
   
   > This looks something either I am missing, or is simply missing?
   
   Yes, what this commit does is to simply change from self-first to parent-first class loading, that's all.  This avoids the `ClassCastException` because there will be a single `Xpp3Dom` class loaded.
   
   If this change is not acceptable for compatibility reason, one possibility would be to extend the extension model to be able to specify self-first or parent-first strategy as an xml attribute on the extension.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org