You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/07/23 09:27:27 UTC

[GitHub] [incubator-iceberg] electrum commented on a change in pull request #304: Add build info to README.

electrum commented on a change in pull request #304: Add build info to README.
URL: https://github.com/apache/incubator-iceberg/pull/304#discussion_r306218190
 
 

 ##########
 File path: README.md
 ##########
 @@ -54,6 +54,11 @@ Community discussions happen primarily on the [dev mailing list][dev-list] or on
 
 Iceberg is built using Gradle 5.2.1.
 
+* To invoke a build and run tests, run: ./gradlew build
 
 Review comment:
   This will look nicer if you use code formatting (backticks):
   ```
   * To invoke a build and run tests, run: `./gradlew build`
   ```
   I'd also simplify it by removing the *", run"* part on all of these:
   ```
   * To invoke a build and run tests: `./gradlew build`
   ```
   It will look like this when rendered:
   * To invoke a build and run tests: `./gradlew build`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org