You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2016/12/20 12:32:26 UTC

Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54892/
-----------------------------------------------------------

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19254
    https://issues.apache.org/jira/browse/AMBARI-19254


Repository: ambari


Description
-------

The job properties of underlying workflow should be submitted when a coordinator is submitted. Similiarly, the job properties of underlying coordinators should be submitted while submitting a bundle job.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4a8ac90 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 15eb1ce 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 28239fa 
  contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 17ff9aa 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 036f529 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 8293dbe 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 6b0ea84 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 6e281d3 

Diff: https://reviews.apache.org/r/54892/diff/


Testing
-------

Manual Testing


Thanks,

Padma Priya N


Re: Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54892/#review159940
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Dec. 20, 2016, 12:32 p.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54892/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 12:32 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19254
>     https://issues.apache.org/jira/browse/AMBARI-19254
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The job properties of underlying workflow should be submitted when a coordinator is submitted. Similiarly, the job properties of underlying coordinators should be submitted while submitting a bundle job.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4a8ac90 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 15eb1ce 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 28239fa 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 17ff9aa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 036f529 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 8293dbe 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 6b0ea84 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 6e281d3 
> 
> Diff: https://reviews.apache.org/r/54892/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54892/#review159942
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 20, 2016, 12:32 p.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54892/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 12:32 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19254
>     https://issues.apache.org/jira/browse/AMBARI-19254
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The job properties of underlying workflow should be submitted when a coordinator is submitted. Similiarly, the job properties of underlying coordinators should be submitted while submitting a bundle job.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4a8ac90 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 15eb1ce 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 28239fa 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 17ff9aa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 036f529 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 8293dbe 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 6b0ea84 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 6e281d3 
> 
> Diff: https://reviews.apache.org/r/54892/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>