[GitHub] [flink-shaded] XComp commented on a diff in pull request #119: Update Flink Shaded dependencies to the latest versions

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #119:
URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1150161507


##########
flink-shaded-asm-9/pom.xml:
##########
@@ -35,7 +35,7 @@ under the License.
 
     <properties>
         <asm.major.version>9</asm.major.version>
-        <asm.version>${asm.major.version}.3</asm.version>
+        <asm.version>${asm.major.version}.5</asm.version>

Review Comment:
   This change seems to have ended up in the wrong commit (`Netty TCNative` instead of `asm`)



##########
flink-shaded-jackson-parent/flink-shaded-jackson-2/src/main/resources/META-INF/NOTICE:
##########
@@ -6,11 +6,11 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-annotations:2.13.4
-- com.fasterxml.jackson.core:jackson-core:2.13.4
-- com.fasterxml.jackson.core:jackson-databind:2.13.4.2
-- com.fasterxml.jackson.dataformat:jackson-dataformat-csv:2.13.4
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.4
-- com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.13.4
-- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.13.4
-- org.yaml:snakeyaml:1.31
+- com.fasterxml.jackson.core:jackson-annotations:2.14.2
+- com.fasterxml.jackson.core:jackson-core:2.14.2
+- com.fasterxml.jackson.core:jackson-databind:2.14.2
+- com.fasterxml.jackson.dataformat:jackson-dataformat-csv:2.14.2
+- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.2
+- com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.14.2
+- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.14.2
+- org.yaml:snakeyaml:1.33

Review Comment:
   Upgrading to 2.0 is not an option here?



##########
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/pom.xml:
##########
@@ -34,7 +34,7 @@ under the License.
 
     <properties>
         <zookeeper.version>3.5.10</zookeeper.version>
-        <curator.version>5.3.0</curator.version>

Review Comment:
   The commit message for the curator update is wrong (we update from 5.3 to 5.4)



##########
flink-shaded-asm-9/src/main/resources/META-INF/NOTICE:
##########
@@ -7,7 +7,7 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the BSD license.
 See bundled license files for details.
 
-- org.ow2.asm:asm:9.3
-- org.ow2.asm:asm-analysis:9.3
-- org.ow2.asm:asm-commons:9.3
-- org.ow2.asm:asm-tree:9.3
\ No newline at end of file
+- org.ow2.asm:asm-analysis:9.5
+- org.ow2.asm:asm-commons:9.5
+- org.ow2.asm:asm-tree:9.5
+- org.ow2.asm:asm:9.5

Review Comment:
   Same with that one: Change is happening in `Netty TCNative` commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org