[jira] [Commented] (YARN-4846) Random failures for TestCapacitySchedulerPreemption#testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers

["Sunil G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247937#comment-15247937 ] 

Sunil G commented on YARN-4846:
-------------------------------

In {{TestCapacitySchedulerPreemption}}, {{maxWaitTime}} is set as 0
{code}
    conf.setInt(CapacitySchedulerConfiguration.PREEMPTION_WAIT_TIME_BEFORE_KILL,
        0);
{code}

So in PCPP, below check in {{cleanupStaledPreemptionCandidates}} can go wrong. 
{code}
      if (preemptionCandidates.get(id) + 2 * maxWaitTime < clock.getTime()) {
        i.remove();
      }
{code}

When {{maxWaitTime}} is 0, there is a high chance that latest {{clock.getTime()}} is always bigger. But when we run in eclipse, it will happen so fast that, time will be same. Hence we are not seeing this error. 

Thanks [~bibinchundatt] for helping in analyzing this test failure along with me. It was really interesting one, good  one  to syncup :)

> Random failures for TestCapacitySchedulerPreemption#testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4846
>                 URL: https://issues.apache.org/jira/browse/YARN-4846
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<0>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerPreemption.testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers(TestCapacitySchedulerPreemption.java:473)
> {noformat}
> https://builds.apache.org/job/PreCommit-YARN-Build/10826/testReport/org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity/TestCapacitySchedulerPreemption/testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)