You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/11/09 16:56:54 UTC

[GitHub] [parquet-mr] gszadovszky commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator

gszadovszky commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-724140466


   It looks good to me.
   We already have the unit test [VersionTest](https://github.com/apache/parquet-mr/blob/master/parquet-common/src/test/java/org/apache/parquet/VersionTest.java) to validate `Version`. Writing this additional test for the code generation made me more confident accepting this change.
   I am not an expert of velocity but looks much better than our original code so I would appreciate your work going forward. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org