You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zhihong Ted Yu (JIRA)" <ji...@apache.org> on 2012/06/23 05:54:42 UTC
[jira] [Reopened] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu reopened HBASE-6246:
-----------------------------------
I was investigating the root cause for frequent TestSplitTransactionOnCluster failures. e.g.:
https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.94/lastCompletedBuild/testReport/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testMasterRestartWhenSplittingIsPartial/
{code}
2012-06-23 02:57:17,388 INFO [Thread-629] regionserver.TestSplitTransactionOnCluster(654): Moving testMasterRestartWhenSplittingIsPartial,,1340420235288.7d985b65a8fb86a516d292158f5d7c40. to vesta.apache.org,34866,1340419933436; metaServerIndex=0
2012-06-23 02:57:17,389 INFO [IPC Server handler 3 on 54803] master.HMaster(1107): Added move plan hri=testMasterRestartWhenSplittingIsPartial,,1340420235288.7d985b65a8fb86a516d292158f5d7c40., src=vesta.apache.org,46324,1340419901533, dest=, running balancer
{code}
We can see clearly that move destination was not picked up by master.
I wonder why the following code was removed in patch for this JIRA ?
{code}
- } else {
- dest = new ServerName(Bytes.toString(destServerName));
{code}
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira