You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:58:25 UTC

[GitHub] [sling-org-apache-sling-jcr-base] cristic83 opened a new pull request, #7: [SLING-11741] Provide alternative terminology for inequitable terms

cristic83 opened a new pull request, #7:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7

   This PR introduces alternative terminology for terms considered un-appropriate. The approach taken was to introduce new configurations named "allowedlist.bypass" and "allowedlist.bundles.regexp" for the `LoginAdminWhitelist` (which is now called `LoginAdminAllowlist`) and `allowlist_name` and `allowlist_bundles` for the `WhitelistFragment` (which is not named `AllowlistFragment`). The `LoginAdminWhitelist` still remains available and, if configured, it is used, so that backwards compatibility is preserved.
   
   Implementation wise, the `LoginAdminWhitelist` has been extracted into an interface named `PermissionCheckerService` that is now implemented both by the `LoginAdminAllowlist` and by the `LoginAdminWhitelist`, but the `LoginAdminWhitelist` has a service ranking higher than the `LoginAdminAllowlist` and the `AbstractSlingRepositoryManager` has been modified to retrieve the `PermissionCheckerService` instead of the `LoginAdminWhitelist`. The bundle's minor version has been increased as a consequence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

Posted by "cziegeler (via GitHub)" <gi...@apache.org>.

cziegeler commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7#issuecomment-1447713439

   Closing due to updated PR #9 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler closed pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

Posted by "cziegeler (via GitHub)" <gi...@apache.org>.

cziegeler closed pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] sonarcloud[bot] commented on pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7#issuecomment-1383951673

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=BUG) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&resolved=false&types=CODE_SMELL)
   
   [![75.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '75.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&metric=new_coverage&view=list) [75.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-base&pullRequest=7&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org