You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2009/06/10 23:30:40 UTC

svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Author: olamy
Date: Wed Jun 10 21:30:40 2009
New Revision: 783525

URL: http://svn.apache.org/viewvc?rev=783525&view=rev
Log:
don't filter doxia-sink-api. users will be still able to run : mvn site:site


Modified:
    maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java Wed Jun 10 21:30:40 2009
@@ -54,7 +54,7 @@
         artifacts.add( "classworlds" );
         artifacts.add( "plexus-classworlds" );
         artifacts.add( "commons-cli" );
-        artifacts.add( "doxia-sink-api" );
+        //artifacts.add( "doxia-sink-api" );
         artifacts.add( "jsch" );
         artifacts.add( "maven-artifact" );
         artifacts.add( "maven-artifact-manager" );



Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 15-Jun-09, at 2:14 PM, Lukas Theussl wrote:
>
> Why is it a problem that doxia is "not really and independent  
> project used by anyone"? Does doxia have any different status than,  
> say, wagon, surefire, archetype...?


I think these are all in the same boat and all a bit of a problem  
actually. I think they have the same status and that's too few  
maintainers and too few releases.

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

A man enjoys his work when he understands the whole and when he
is responsible for the quality of the whole

  -- Christopher Alexander, A Pattern Language


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Lukas Theussl <lt...@apache.org>.

Jason van Zyl wrote:
> 
> On 15-Jun-09, at 10:29 AM, Lukas Theussl wrote:
> 
>>
>>
>> Jason van Zyl wrote:
>>> On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
>>>>
>>>> Hi Olivier,
>>>>
>>>> How does this relate to MNG-3402?
>>>>
>>> This doesn't relate to anything in 3.x because it's not going to be 
>>> an issue because no doxia classes will be distributed with 3.x. Not 
>>> sure what you guys are planning for 3.x.
>>
>>
>> There were never any doxia classes distributed with any version of 
>> maven, that's not the issue.
> 
> doxia-sink and yes it is an issue. This particular issue aside.

Well that's exacly the point about MNG-3402. The only place where a doxia class is 
referenced in maven 2.x core is MavenReport in reporting-api, but the Sink there 
is the old codehaus Sink. This interface, apart from getting deprecated, has not 
changed since I don't know when. So even though the MavenArtifactFilterManager 
puts the maven Sink in front in your class path, the class is never actually 
referenced.

> 
>> The problem is (was) that maven 2.x is filtering the doxia version 
>> (MNG-3402), which makes it impossible for plugins to use their own 
>> (updated) version of doxia (usecase: pdf plugin). The development of 
>> doxia was hindered not by it's coupling to maven, but by maven 
>> refusing any update to doxia.
> 
> The that immediately presents the problem we have. If doxia is hindered 
> by Maven not updating then it's not really and independent project used 
> by anyone.

I think you misunderstood me or maybe I misunderstand you. I did not say "doxia is 
hindered by Maven not updating", I said "...by maven refusing any update to 
doxia". The current site plugin on trunk is still using doxia 1.0 which is 
effectively more than a year old now and has seen only few changes the year before 
that. Doxia 1.1 was released 3 months ago and since then we've solved 47 issues 
for 1.1.1. It would be released by now if it wasn't for those new Apache 
requirements. Together with the ~100 issues solved in 1.1, this makes ~150 solved 
issues that current maven site users are still waiting for.

Why is it a problem that doxia is "not really and independent project used by 
anyone"? Does doxia have any different status than, say, wagon, surefire, 
archetype...?

> 
>>
>> But anyway, I'm happy that all this will be no issue in 3.x :)
>>
> 
> Nope.

Yes, really, I am happy...

> Doxia will truly be an independent project and will survive or die 
> based on the value provided reporting implementation created with it.

Not sure how to parse that and again, don't know what you mean with "independent 
project"?


> 
>> -Lukas
>>
>>
>>>> Just wondering because we had a lot of discussions about this issue 
>>>> in the past wrt Doxia release plan [1], and from other peoples' 
>>>> comments I always got the impression that it will lead to trouble... 
>>>> even though I never noticed anything myself.
>>>>
>>>> -Lukas
>>>>
>>>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>>>
>>>>
>>>>
>>>> olamy@apache.org wrote:
>>>>> Author: olamy
>>>>> Date: Wed Jun 10 21:30:40 2009
>>>>> New Revision: 783525
>>>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>>>> Log:
>>>>> don't filter doxia-sink-api. users will be still able to run : mvn 
>>>>> site:site
>>>>> Modified:
>>>>>   
>>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>>>
>>>>> Modified: 
>>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>>>
>>>>> URL: 
>>>>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff 
>>>>>
>>>>> ============================================================================== 
>>>>>
>>>>> --- 
>>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>>> (original)
>>>>> +++ 
>>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>>> Wed Jun 10 21:30:40 2009
>>>>> @@ -54,7 +54,7 @@
>>>>>        artifacts.add( "classworlds" );
>>>>>        artifacts.add( "plexus-classworlds" );
>>>>>        artifacts.add( "commons-cli" );
>>>>> -        artifacts.add( "doxia-sink-api" );
>>>>> +        //artifacts.add( "doxia-sink-api" );
>>>>>        artifacts.add( "jsch" );
>>>>>        artifacts.add( "maven-artifact" );
>>>>>        artifacts.add( "maven-artifact-manager" );
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>> Thanks,
>>> Jason
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/SonatypeNexus
>>> http://twitter.com/SonatypeM2E
>>> ----------------------------------------------------------
>>> A man enjoys his work when he understands the whole and when he
>>> is responsible for the quality of the whole
>>> -- Christopher Alexander, A Pattern Language
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
> 
> Thanks,
> 
> Jason
> 
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/SonatypeNexus
> http://twitter.com/SonatypeM2E
> ----------------------------------------------------------
> 
> the course of true love never did run smooth ...
> 
>  -- Shakespeare
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 15-Jun-09, at 10:29 AM, Lukas Theussl wrote:

>
>
> Jason van Zyl wrote:
>> On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
>>>
>>> Hi Olivier,
>>>
>>> How does this relate to MNG-3402?
>>>
>> This doesn't relate to anything in 3.x because it's not going to be  
>> an issue because no doxia classes will be distributed with 3.x. Not  
>> sure what you guys are planning for 3.x.
>
>
> There were never any doxia classes distributed with any version of  
> maven, that's not the issue.

doxia-sink and yes it is an issue. This particular issue aside.

> The problem is (was) that maven 2.x is filtering the doxia version  
> (MNG-3402), which makes it impossible for plugins to use their own  
> (updated) version of doxia (usecase: pdf plugin). The development of  
> doxia was hindered not by it's coupling to maven, but by maven  
> refusing any update to doxia.

The that immediately presents the problem we have. If doxia is  
hindered by Maven not updating then it's not really and independent  
project used by anyone.

>
> But anyway, I'm happy that all this will be no issue in 3.x :)
>

Nope. Doxia will truly be an independent project and will survive or  
die based on the value provided reporting implementation created with  
it.

> -Lukas
>
>
>>> Just wondering because we had a lot of discussions about this  
>>> issue in the past wrt Doxia release plan [1], and from other  
>>> peoples' comments I always got the impression that it will lead to  
>>> trouble... even though I never noticed anything myself.
>>>
>>> -Lukas
>>>
>>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>>
>>>
>>>
>>> olamy@apache.org wrote:
>>>> Author: olamy
>>>> Date: Wed Jun 10 21:30:40 2009
>>>> New Revision: 783525
>>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>>> Log:
>>>> don't filter doxia-sink-api. users will be still able to run :  
>>>> mvn site:site
>>>> Modified:
>>>>   maven/components/trunk/maven-core/src/main/java/org/apache/ 
>>>> maven/DefaultArtifactFilterManager.java
>>>> Modified: maven/components/trunk/maven-core/src/main/java/org/ 
>>>> apache/maven/DefaultArtifactFilterManager.java
>>>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> ===================================================================
>>>> --- maven/components/trunk/maven-core/src/main/java/org/apache/ 
>>>> maven/DefaultArtifactFilterManager.java (original)
>>>> +++ maven/components/trunk/maven-core/src/main/java/org/apache/ 
>>>> maven/DefaultArtifactFilterManager.java Wed Jun 10 21:30:40 2009
>>>> @@ -54,7 +54,7 @@
>>>>        artifacts.add( "classworlds" );
>>>>        artifacts.add( "plexus-classworlds" );
>>>>        artifacts.add( "commons-cli" );
>>>> -        artifacts.add( "doxia-sink-api" );
>>>> +        //artifacts.add( "doxia-sink-api" );
>>>>        artifacts.add( "jsch" );
>>>>        artifacts.add( "maven-artifact" );
>>>>        artifacts.add( "maven-artifact-manager" );
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>> Thanks,
>> Jason
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/SonatypeNexus
>> http://twitter.com/SonatypeM2E
>> ----------------------------------------------------------
>> A man enjoys his work when he understands the whole and when he
>> is responsible for the quality of the whole
>> -- Christopher Alexander, A Pattern Language
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

the course of true love never did run smooth ...

  -- Shakespeare


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Lukas Theussl <lt...@apache.org>.

Jason van Zyl wrote:
> 
> On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
> 
>>
>> Hi Olivier,
>>
>> How does this relate to MNG-3402?
>>
> 
> This doesn't relate to anything in 3.x because it's not going to be an 
> issue because no doxia classes will be distributed with 3.x. Not sure 
> what you guys are planning for 3.x.


There were never any doxia classes distributed with any version of maven, that's 
not the issue. The problem is (was) that maven 2.x is filtering the doxia version 
(MNG-3402), which makes it impossible for plugins to use their own (updated) 
version of doxia (usecase: pdf plugin). The development of doxia was hindered not 
by it's coupling to maven, but by maven refusing any update to doxia.

But anyway, I'm happy that all this will be no issue in 3.x :)

-Lukas


> 
>> Just wondering because we had a lot of discussions about this issue in 
>> the past wrt Doxia release plan [1], and from other peoples' comments 
>> I always got the impression that it will lead to trouble... even 
>> though I never noticed anything myself.
>>
>> -Lukas
>>
>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>
>>
>>
>> olamy@apache.org wrote:
>>> Author: olamy
>>> Date: Wed Jun 10 21:30:40 2009
>>> New Revision: 783525
>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>> Log:
>>> don't filter doxia-sink-api. users will be still able to run : mvn 
>>> site:site
>>> Modified:
>>>    
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>
>>> Modified: 
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>> (original)
>>> +++ 
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java 
>>> Wed Jun 10 21:30:40 2009
>>> @@ -54,7 +54,7 @@
>>>         artifacts.add( "classworlds" );
>>>         artifacts.add( "plexus-classworlds" );
>>>         artifacts.add( "commons-cli" );
>>> -        artifacts.add( "doxia-sink-api" );
>>> +        //artifacts.add( "doxia-sink-api" );
>>>         artifacts.add( "jsch" );
>>>         artifacts.add( "maven-artifact" );
>>>         artifacts.add( "maven-artifact-manager" );
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
> 
> Thanks,
> 
> Jason
> 
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/SonatypeNexus
> http://twitter.com/SonatypeM2E
> ----------------------------------------------------------
> 
> A man enjoys his work when he understands the whole and when he
> is responsible for the quality of the whole
> 
>  -- Christopher Alexander, A Pattern Language
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:

>
> Hi Olivier,
>
> How does this relate to MNG-3402?
>

This doesn't relate to anything in 3.x because it's not going to be an  
issue because no doxia classes will be distributed with 3.x. Not sure  
what you guys are planning for 3.x.

> Just wondering because we had a lot of discussions about this issue  
> in the past wrt Doxia release plan [1], and from other peoples'  
> comments I always got the impression that it will lead to trouble...  
> even though I never noticed anything myself.
>
> -Lukas
>
> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>
>
>
> olamy@apache.org wrote:
>> Author: olamy
>> Date: Wed Jun 10 21:30:40 2009
>> New Revision: 783525
>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>> Log:
>> don't filter doxia-sink-api. users will be still able to run : mvn  
>> site:site
>> Modified:
>>    maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>> DefaultArtifactFilterManager.java
>> Modified: maven/components/trunk/maven-core/src/main/java/org/ 
>> apache/maven/DefaultArtifactFilterManager.java
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- maven/components/trunk/maven-core/src/main/java/org/apache/ 
>> maven/DefaultArtifactFilterManager.java (original)
>> +++ maven/components/trunk/maven-core/src/main/java/org/apache/ 
>> maven/DefaultArtifactFilterManager.java Wed Jun 10 21:30:40 2009
>> @@ -54,7 +54,7 @@
>>         artifacts.add( "classworlds" );
>>         artifacts.add( "plexus-classworlds" );
>>         artifacts.add( "commons-cli" );
>> -        artifacts.add( "doxia-sink-api" );
>> +        //artifacts.add( "doxia-sink-api" );
>>         artifacts.add( "jsch" );
>>         artifacts.add( "maven-artifact" );
>>         artifacts.add( "maven-artifact-manager" );
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

A man enjoys his work when he understands the whole and when he
is responsible for the quality of the whole

  -- Christopher Alexander, A Pattern Language


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Lukas Theussl <lt...@apache.org>.
Just in case, are you aware of these:

http://maven.apache.org/doxia/whatsnew-1.1.html#Binary_Incompatibility
http://maven.apache.org/doxia/developers/maven-integration.html

maybe it helps...

-Lukas


Olivier Lamy wrote:
> Hi,
> It looks related sure :-).
> I didn't notice the existing jira entry.
> I'm currently made some tests with current trunk on some projects
> (company ones and oss ones) to test backward compatibility/
> 
> And I have noticed I couldn't run anymore : mvn site:site (just
> generate the site works now all reporting looks to be an other story
> :-) ).
> 
> --
> Olivier
> 
> 2009/6/11 Lukas Theussl <lt...@apache.org>:
>> Hi Olivier,
>>
>> How does this relate to MNG-3402?
>>
>> Just wondering because we had a lot of discussions about this issue in the
>> past wrt Doxia release plan [1], and from other peoples' comments I always
>> got the impression that it will lead to trouble... even though I never
>> noticed anything myself.
>>
>> -Lukas
>>
>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>
>>
>>
>> olamy@apache.org wrote:
>>> Author: olamy
>>> Date: Wed Jun 10 21:30:40 2009
>>> New Revision: 783525
>>>
>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>> Log:
>>> don't filter doxia-sink-api. users will be still able to run : mvn
>>> site:site
>>>
>>>
>>> Modified:
>>>
>>>  maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>>
>>> Modified:
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> URL:
>>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> (original)
>>> +++
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> Wed Jun 10 21:30:40 2009
>>> @@ -54,7 +54,7 @@
>>>         artifacts.add( "classworlds" );
>>>         artifacts.add( "plexus-classworlds" );
>>>         artifacts.add( "commons-cli" );
>>> -        artifacts.add( "doxia-sink-api" );
>>> +        //artifacts.add( "doxia-sink-api" );
>>>         artifacts.add( "jsch" );
>>>         artifacts.add( "maven-artifact" );
>>>         artifacts.add( "maven-artifact-manager" );
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Olivier Lamy <ol...@apache.org>.
Hi,
It looks related sure :-).
I didn't notice the existing jira entry.
I'm currently made some tests with current trunk on some projects
(company ones and oss ones) to test backward compatibility/

And I have noticed I couldn't run anymore : mvn site:site (just
generate the site works now all reporting looks to be an other story
:-) ).

--
Olivier

2009/6/11 Lukas Theussl <lt...@apache.org>:
>
> Hi Olivier,
>
> How does this relate to MNG-3402?
>
> Just wondering because we had a lot of discussions about this issue in the
> past wrt Doxia release plan [1], and from other peoples' comments I always
> got the impression that it will lead to trouble... even though I never
> noticed anything myself.
>
> -Lukas
>
> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>
>
>
> olamy@apache.org wrote:
>>
>> Author: olamy
>> Date: Wed Jun 10 21:30:40 2009
>> New Revision: 783525
>>
>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>> Log:
>> don't filter doxia-sink-api. users will be still able to run : mvn
>> site:site
>>
>>
>> Modified:
>>
>>  maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>
>> Modified:
>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>> URL:
>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>>
>> ==============================================================================
>> ---
>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>> (original)
>> +++
>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>> Wed Jun 10 21:30:40 2009
>> @@ -54,7 +54,7 @@
>>         artifacts.add( "classworlds" );
>>         artifacts.add( "plexus-classworlds" );
>>         artifacts.add( "commons-cli" );
>> -        artifacts.add( "doxia-sink-api" );
>> +        //artifacts.add( "doxia-sink-api" );
>>         artifacts.add( "jsch" );
>>         artifacts.add( "maven-artifact" );
>>         artifacts.add( "maven-artifact-manager" );
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Benjamin Bentmann <be...@udo.edu>.
Olivier Lamy wrote:

> I have started on it (branch created [1]) and I have an issue building
> with the current trunk.
> [...]
> o Invalid repository apache.snapshots in POM org.apache:apache:4:
> org.apache.maven.model.Repository cannot be cast to
> org.apache.maven.artifact.repository.ArtifactRepository

You need to use maven-remote-resources-plugin:1.0.1-SNAPSHOT to get the 
fix for MRRESOURCES-35.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Olivier Lamy <ol...@apache.org>.
Hi,
I have started on it (branch created [1]) and I have an issue building
with the current trunk.
The log says :

org.apache.maven.project.ProjectBuildingException: Failed to build
project for /local/olamy/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
for project [unknown] at
/local/olamy/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
        at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:118)
        at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:179)
        at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:51)
        at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:79)
        at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:67)
        at org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.getProjects(ProcessRemoteResourcesMojo.java:505)
        at org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.configureVelocityContext(ProcessRemoteResourcesMojo.java:665)

.....

Caused by: org.apache.maven.model.ModelBuildingException: 1 problem
was encountered during construction of the effective model:
o Invalid repository apache.snapshots in POM org.apache:apache:4:
org.apache.maven.model.Repository cannot be cast to
org.apache.maven.artifact.repository.ArtifactRepository

        at org.apache.maven.model.DefaultModelBuilder.build(DefaultModelBuilder.java:191)
        at org.apache.maven.model.DefaultModelBuilder.build(DefaultModelBuilder.java:106)
        at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:113)
        ... 21 more

?

--
Olivier

[1] https://svn.apache.org/repos/asf/maven/plugins/branches/maven-site-plugin-3.x/

2009/6/16 Jason van Zyl <jv...@sonatype.com>:
>
> On 16-Jun-09, at 12:42 PM, Brett Porter wrote:
>
>>
>> On 14/06/2009, at 3:53 PM, Jason van Zyl wrote:
>>
>>> What we can do internally for people who want to use their POMs "as-is"
>>> with 3.x is to provide some internal mapping from the POM to the
>>> configuration element of the new site-plugin. When 3.0 is release no one
>>> should have to change their POMs i.e flip all the configuration into the
>>> maven-site-plugin configuration but they will have to use the new version of
>>> the site-plugin.
>>
>> What about using the site lifecycle (which could be moved to the site
>> plugin if they can be loaded from there easily) so that the reports become
>> normal plugin goals? The advantage is that it works with Maven 2.x today.
>>
>
> I'm not sure what you're talking about, it's going to work exactly as it
> does in 2.x.
>
>> - Brett
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/SonatypeNexus
> http://twitter.com/SonatypeM2E
> ----------------------------------------------------------
>
> We all have problems. How we deal with them is a measure of our worth.
>
>  -- Unknown
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 16-Jun-09, at 1:46 PM, Brett Porter wrote:

>
> On 16/06/2009, at 10:09 PM, Jason van Zyl wrote:
>
>>
>> On 16-Jun-09, at 12:42 PM, Brett Porter wrote:
>>
>>>
>>> On 14/06/2009, at 3:53 PM, Jason van Zyl wrote:
>>>
>>>> What we can do internally for people who want to use their POMs  
>>>> "as-is" with 3.x is to provide some internal mapping from the POM  
>>>> to the configuration element of the new site-plugin. When 3.0 is  
>>>> release no one should have to change their POMs i.e flip all the  
>>>> configuration into the maven-site-plugin configuration but they  
>>>> will have to use the new version of the site-plugin.
>>>
>>> What about using the site lifecycle (which could be moved to the  
>>> site plugin if they can be loaded from there easily) so that the  
>>> reports become normal plugin goals? The advantage is that it works  
>>> with Maven 2.x today.
>>>
>>
>> I'm not sure what you're talking about, it's going to work exactly  
>> as it does in 2.x.
>
> Yep, sorry I misread what you meant by mapping.
>
> Still, as an implementation method, utilising the lifecycle and  
> normal plugin goals to generate the data needed, then having the  
> site plugin only render tie that up together rather than managing  
> execution (as it does via the core now) would give more flexibility  
> for the future.
>

Custom lifecycle will still work as they do apart from being more  
dynamic. Whether a lifecycle or just plugins with goals will be up to  
whoever rewrites it. The way it is now or not using a custom lifecycle  
won't make any difference to 3.x itself.

> - Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.

   -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Brett Porter <br...@apache.org>.
On 16/06/2009, at 10:09 PM, Jason van Zyl wrote:

>
> On 16-Jun-09, at 12:42 PM, Brett Porter wrote:
>
>>
>> On 14/06/2009, at 3:53 PM, Jason van Zyl wrote:
>>
>>> What we can do internally for people who want to use their POMs  
>>> "as-is" with 3.x is to provide some internal mapping from the POM  
>>> to the configuration element of the new site-plugin. When 3.0 is  
>>> release no one should have to change their POMs i.e flip all the  
>>> configuration into the maven-site-plugin configuration but they  
>>> will have to use the new version of the site-plugin.
>>
>> What about using the site lifecycle (which could be moved to the  
>> site plugin if they can be loaded from there easily) so that the  
>> reports become normal plugin goals? The advantage is that it works  
>> with Maven 2.x today.
>>
>
> I'm not sure what you're talking about, it's going to work exactly  
> as it does in 2.x.

Yep, sorry I misread what you meant by mapping.

Still, as an implementation method, utilising the lifecycle and normal  
plugin goals to generate the data needed, then having the site plugin  
only render tie that up together rather than managing execution (as it  
does via the core now) would give more flexibility for the future.

- Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 16-Jun-09, at 12:42 PM, Brett Porter wrote:

>
> On 14/06/2009, at 3:53 PM, Jason van Zyl wrote:
>
>> What we can do internally for people who want to use their POMs "as- 
>> is" with 3.x is to provide some internal mapping from the POM to  
>> the configuration element of the new site-plugin. When 3.0 is  
>> release no one should have to change their POMs i.e flip all the  
>> configuration into the maven-site-plugin configuration but they  
>> will have to use the new version of the site-plugin.
>
> What about using the site lifecycle (which could be moved to the  
> site plugin if they can be loaded from there easily) so that the  
> reports become normal plugin goals? The advantage is that it works  
> with Maven 2.x today.
>

I'm not sure what you're talking about, it's going to work exactly as  
it does in 2.x.

> - Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

We all have problems. How we deal with them is a measure of our worth.

  -- Unknown


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Brett Porter <br...@apache.org>.
On 14/06/2009, at 3:53 PM, Jason van Zyl wrote:

> What we can do internally for people who want to use their POMs "as- 
> is" with 3.x is to provide some internal mapping from the POM to the  
> configuration element of the new site-plugin. When 3.0 is release no  
> one should have to change their POMs i.e flip all the configuration  
> into the maven-site-plugin configuration but they will have to use  
> the new version of the site-plugin.

What about using the site lifecycle (which could be moved to the site  
plugin if they can be loaded from there easily) so that the reports  
become normal plugin goals? The advantage is that it works with Maven  
2.x today.

- Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
On 13-Jun-09, at 7:21 AM, Olivier Lamy wrote:

> Hi,
> It sounds good to remove link between core and doxia..
> What is your idea ?
> Creating a new plugin ? Moving logic to the site plugin ? Move logic
> to maven-reporting-impl or something new ?

I would just encapsulate it all in the maven-site-plugin. I would  
honestly just put everything there including all your existing  
implementations and even Doxia. The stuff is not used anywhere else  
outside the context of the maven-site-plugin. By this I specifically  
mean just make a multi-module build of the maven-site-plugin and just  
include everything that's used there: doxia, site-tools, and whatever  
else. Have it all be decoupled from the core, focus on getting it all  
working together, think about modularization again in the future.  
Doxia just really has never taken off as a separate project: it's just  
not used outside of the site plugin and at this point I think it's  
highly unlikely it will. Just get it all working together in a new  
encapsulated system would be my suggestion.

> If I can help, let me know (I'd like to participate on current trunk
> but as a newbie here I don't wan't to break everything :-) ).
>

You can't break anything on trunk insofar as the maven-site-plugin  
because there just isn't any reporting functionality left in there  
anymore. You should be able to restore complete functionality to the  
maven-site-plugin and when we find things that are missing that you  
need it can be added. You need to access the plugin manager to  
configure and run the reports, and you'll probably need to perform  
some operations at the beginning of the lifecycle and you'll want to  
do some aggregation at the end of the lifecycle.

I'm happy to help with any internal changes that might need to be  
made. But I would:

- branch the site plugin
- incorporate the configuration that is currently required in the POM  
for reporting and include that in the site plugin
- leverage the core to configure and execute the reports

What we can do internally for people who want to use their POMs "as- 
is" with 3.x is to provide some internal mapping from the POM to the  
configuration element of the new site-plugin. When 3.0 is release no  
one should have to change their POMs i.e flip all the configuration  
into the maven-site-plugin configuration but they will have to use the  
new version of the site-plugin.

If you want to help with this that would be very helpful.

> Thanks,
> --
> Olivier
>
> 2009/6/11 Jason van Zyl <jv...@sonatype.com>:
>> There's nothing Doxia specific in the core, that was just a lingering
>> element in the POM.
>>
>> Plan in a nutshell is that the entire existing reporting mechanism  
>> will be
>> encapsulated in the site plugin and I will provide any hooks in the
>> lifecycle to make it work.
>>
>> The mixture of reports and plugins caused such a massive amount of  
>> pollution
>> it made it impossible to generalize the plugin manager. It was just  
>> a huge
>> mess.
>>
>> Everything has to be extensible including reporting and it can all be
>> bundled up in a plugin. One of the requirements for the release of  
>> 3.0 is to
>> have the infrastructure to support the current reporting system as  
>> a plugin.
>>
>> I can make a first pass at the plugin and then you guys can pick it  
>> up.
>>
>> On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
>>
>>>
>>> Hi Olivier,
>>>
>>> How does this relate to MNG-3402?
>>>
>>> Just wondering because we had a lot of discussions about this  
>>> issue in the
>>> past wrt Doxia release plan [1], and from other peoples' comments  
>>> I always
>>> got the impression that it will lead to trouble... even though I  
>>> never
>>> noticed anything myself.
>>>
>>> -Lukas
>>>
>>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>>
>>>
>>>
>>> olamy@apache.org wrote:
>>>>
>>>> Author: olamy
>>>> Date: Wed Jun 10 21:30:40 2009
>>>> New Revision: 783525
>>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>>> Log:
>>>> don't filter doxia-sink-api. users will be still able to run : mvn
>>>> site:site
>>>> Modified:
>>>>
>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>>>> DefaultArtifactFilterManager.java
>>>> Modified:
>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>>>> DefaultArtifactFilterManager.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>>>>
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> ===================================================================
>>>> ---
>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>>>> DefaultArtifactFilterManager.java
>>>> (original)
>>>> +++
>>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>>>> DefaultArtifactFilterManager.java
>>>> Wed Jun 10 21:30:40 2009
>>>> @@ -54,7 +54,7 @@
>>>>        artifacts.add( "classworlds" );
>>>>        artifacts.add( "plexus-classworlds" );
>>>>        artifacts.add( "commons-cli" );
>>>> -        artifacts.add( "doxia-sink-api" );
>>>> +        //artifacts.add( "doxia-sink-api" );
>>>>        artifacts.add( "jsch" );
>>>>        artifacts.add( "maven-artifact" );
>>>>        artifacts.add( "maven-artifact-manager" );
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> http://twitter.com/SonatypeNexus
>> http://twitter.com/SonatypeM2E
>> ----------------------------------------------------------
>>
>> In short, man creates for himself a new religion of a rational
>> and technical order to justify his work and to be justified in it.
>>
>>  -- Jacques Ellul, The Technological Society
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

Our achievements speak for themselves. What we have to keep track
of are our failures, discouragements and doubts. We tend to forget
the past difficulties, the many false starts, and the painful
groping. We see our past achievements as the end result of a
clean forward thrust, and our present difficulties as
signs of decline and decay.

  -- Eric Hoffer, Reflections on the Human Condition


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Olivier Lamy <ol...@apache.org>.
Hi,
It sounds good to remove link between core and doxia..
What is your idea ?
Creating a new plugin ? Moving logic to the site plugin ? Move logic
to maven-reporting-impl or something new ?
If I can help, let me know (I'd like to participate on current trunk
but as a newbie here I don't wan't to break everything :-) ).

Thanks,
--
Olivier

2009/6/11 Jason van Zyl <jv...@sonatype.com>:
> There's nothing Doxia specific in the core, that was just a lingering
> element in the POM.
>
> Plan in a nutshell is that the entire existing reporting mechanism will be
> encapsulated in the site plugin and I will provide any hooks in the
> lifecycle to make it work.
>
> The mixture of reports and plugins caused such a massive amount of pollution
> it made it impossible to generalize the plugin manager. It was just a huge
> mess.
>
> Everything has to be extensible including reporting and it can all be
> bundled up in a plugin. One of the requirements for the release of 3.0 is to
> have the infrastructure to support the current reporting system as a plugin.
>
> I can make a first pass at the plugin and then you guys can pick it up.
>
> On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
>
>>
>> Hi Olivier,
>>
>> How does this relate to MNG-3402?
>>
>> Just wondering because we had a lot of discussions about this issue in the
>> past wrt Doxia release plan [1], and from other peoples' comments I always
>> got the impression that it will lead to trouble... even though I never
>> noticed anything myself.
>>
>> -Lukas
>>
>> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>>
>>
>>
>> olamy@apache.org wrote:
>>>
>>> Author: olamy
>>> Date: Wed Jun 10 21:30:40 2009
>>> New Revision: 783525
>>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>>> Log:
>>> don't filter doxia-sink-api. users will be still able to run : mvn
>>> site:site
>>> Modified:
>>>
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> Modified:
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> URL:
>>> http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> (original)
>>> +++
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
>>> Wed Jun 10 21:30:40 2009
>>> @@ -54,7 +54,7 @@
>>>        artifacts.add( "classworlds" );
>>>        artifacts.add( "plexus-classworlds" );
>>>        artifacts.add( "commons-cli" );
>>> -        artifacts.add( "doxia-sink-api" );
>>> +        //artifacts.add( "doxia-sink-api" );
>>>        artifacts.add( "jsch" );
>>>        artifacts.add( "maven-artifact" );
>>>        artifacts.add( "maven-artifact-manager" );
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/SonatypeNexus
> http://twitter.com/SonatypeM2E
> ----------------------------------------------------------
>
> In short, man creates for himself a new religion of a rational
> and technical order to justify his work and to be justified in it.
>
>  -- Jacques Ellul, The Technological Society
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Jason van Zyl <jv...@sonatype.com>.
There's nothing Doxia specific in the core, that was just a lingering  
element in the POM.

Plan in a nutshell is that the entire existing reporting mechanism  
will be encapsulated in the site plugin and I will provide any hooks  
in the lifecycle to make it work.

The mixture of reports and plugins caused such a massive amount of  
pollution it made it impossible to generalize the plugin manager. It  
was just a huge mess.

Everything has to be extensible including reporting and it can all be  
bundled up in a plugin. One of the requirements for the release of 3.0  
is to have the infrastructure to support the current reporting system  
as a plugin.

I can make a first pass at the plugin and then you guys can pick it up.

On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:

>
> Hi Olivier,
>
> How does this relate to MNG-3402?
>
> Just wondering because we had a lot of discussions about this issue  
> in the past wrt Doxia release plan [1], and from other peoples'  
> comments I always got the impression that it will lead to trouble...  
> even though I never noticed anything myself.
>
> -Lukas
>
> [1] http://www.nabble.com/MNG-3402-tt17207692.html
>
>
>
> olamy@apache.org wrote:
>> Author: olamy
>> Date: Wed Jun 10 21:30:40 2009
>> New Revision: 783525
>> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
>> Log:
>> don't filter doxia-sink-api. users will be still able to run : mvn  
>> site:site
>> Modified:
>>    maven/components/trunk/maven-core/src/main/java/org/apache/maven/ 
>> DefaultArtifactFilterManager.java
>> Modified: maven/components/trunk/maven-core/src/main/java/org/ 
>> apache/maven/DefaultArtifactFilterManager.java
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- maven/components/trunk/maven-core/src/main/java/org/apache/ 
>> maven/DefaultArtifactFilterManager.java (original)
>> +++ maven/components/trunk/maven-core/src/main/java/org/apache/ 
>> maven/DefaultArtifactFilterManager.java Wed Jun 10 21:30:40 2009
>> @@ -54,7 +54,7 @@
>>         artifacts.add( "classworlds" );
>>         artifacts.add( "plexus-classworlds" );
>>         artifacts.add( "commons-cli" );
>> -        artifacts.add( "doxia-sink-api" );
>> +        //artifacts.add( "doxia-sink-api" );
>>         artifacts.add( "jsch" );
>>         artifacts.add( "maven-artifact" );
>>         artifacts.add( "maven-artifact-manager" );
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.

   -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r783525 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java

Posted by Lukas Theussl <lt...@apache.org>.
Hi Olivier,

How does this relate to MNG-3402?

Just wondering because we had a lot of discussions about this issue in the past 
wrt Doxia release plan [1], and from other peoples' comments I always got the 
impression that it will lead to trouble... even though I never noticed anything 
myself.

-Lukas

[1] http://www.nabble.com/MNG-3402-tt17207692.html



olamy@apache.org wrote:
> Author: olamy
> Date: Wed Jun 10 21:30:40 2009
> New Revision: 783525
> 
> URL: http://svn.apache.org/viewvc?rev=783525&view=rev
> Log:
> don't filter doxia-sink-api. users will be still able to run : mvn site:site
> 
> 
> Modified:
>     maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
> 
> Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
> ==============================================================================
> --- maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java (original)
> +++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java Wed Jun 10 21:30:40 2009
> @@ -54,7 +54,7 @@
>          artifacts.add( "classworlds" );
>          artifacts.add( "plexus-classworlds" );
>          artifacts.add( "commons-cli" );
> -        artifacts.add( "doxia-sink-api" );
> +        //artifacts.add( "doxia-sink-api" );
>          artifacts.add( "jsch" );
>          artifacts.add( "maven-artifact" );
>          artifacts.add( "maven-artifact-manager" );
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org