You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/09/22 13:57:26 UTC

[jira] [Created] (HADOOP-7670) test-patch should not -1 for just build changes

test-patch should not -1 for just build changes
-----------------------------------------------

                 Key: HADOOP-7670
                 URL: https://issues.apache.org/jira/browse/HADOOP-7670
             Project: Hadoop Common
          Issue Type: Improvement
          Components: build
    Affects Versions: 0.24.0
            Reporter: Robert Joseph Evans
            Assignee: Robert Joseph Evans
            Priority: Minor


If all a patch changed was build scripts then there should be an exemption to the required test changes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7670) test-patch should not -1 for just build changes

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112697#comment-13112697 ] 

Suresh Srinivas commented on HADOOP-7670:
-----------------------------------------

Is this really necessary? There are many instances, not just build scripts, when test-patch gives -1. The developer can provide explanation, on the reason why test is not included and can get the code committed.

> test-patch should not -1 for just build changes
> -----------------------------------------------
>
>                 Key: HADOOP-7670
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7670
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Minor
>
> If all a patch changed was build scripts then there should be an exemption to the required test changes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7670) test-patch should not -1 for just build changes

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112705#comment-13112705 ] 

Robert Joseph Evans commented on HADOOP-7670:
---------------------------------------------

That is why I marked it as minor.  It is not hard to do, and I thought it would make things cleaner.  If you disagree go ahead and close this.  It is not important.

> test-patch should not -1 for just build changes
> -----------------------------------------------
>
>                 Key: HADOOP-7670
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7670
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Minor
>
> If all a patch changed was build scripts then there should be an exemption to the required test changes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira