[GitHub] [lucene-solr] janhoy commented on a change in pull request #946: SOLR-13835 HttpSolrCall produces incorrect extra AuditEvent on AuthorizationResponse.PROMPT

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #946: SOLR-13835 HttpSolrCall produces incorrect extra AuditEvent on AuthorizationResponse.PROMPT
URL: https://github.com/apache/lucene-solr/pull/946#discussion_r335483832
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java
 ##########
 @@ -232,7 +234,7 @@ public void testBasicAuth() throws Exception {
         HttpSolrClient.RemoteSolrException e = expectThrows(HttpSolrClient.RemoteSolrException.class, () -> {
           new UpdateRequest().deleteByQuery("*:*").process(aNewClient, COLLECTION);
         });
-        assertTrue(e.getMessage().contains("Unauthorized request"));
+        assertTrue(e.getMessage(), e.getMessage().contains("Authentication failed"));
 
 Review comment:
   Earlier both 401 and 403 responses would print the text "Unauthorized request" due to the fall-through. After this fix we also changed the text for 401 response, making this test fail. Don't know why Authorization plugin returns 401 though, the password is correct..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org