You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by he...@apache.org on 2020/05/28 20:11:11 UTC
[commons-jexl] 03/04: JEXL-249: nitpicks for findbugs Task
#JEXL-249 - Java 1.8 as minimum supported version
This is an automated email from the ASF dual-hosted git repository.
henrib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
commit 07bdc85a1420665a8123aafc6767e2b5054ae795
Author: henrib <he...@apache.org>
AuthorDate: Thu May 28 22:09:27 2020 +0200
JEXL-249: nitpicks for findbugs
Task #JEXL-249 - Java 1.8 as minimum supported version
---
src/main/java/org/apache/commons/jexl3/JexlArithmetic.java | 3 ++-
src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java | 1 -
.../java/org/apache/commons/jexl3/internal/TemplateInterpreter.java | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/apache/commons/jexl3/JexlArithmetic.java b/src/main/java/org/apache/commons/jexl3/JexlArithmetic.java
index 61335f9..5b1c4a2 100644
--- a/src/main/java/org/apache/commons/jexl3/JexlArithmetic.java
+++ b/src/main/java/org/apache/commons/jexl3/JexlArithmetic.java
@@ -21,6 +21,7 @@ import org.apache.commons.jexl3.introspection.JexlMethod;
import java.lang.reflect.Array;
import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
import java.math.BigDecimal;
import java.math.BigInteger;
import java.math.MathContext;
@@ -210,7 +211,7 @@ public class JexlArithmetic {
if (ctor != null) {
try {
return ctor.newInstance(astrict, bigdContext, bigdScale);
- } catch (Exception xany) {
+ } catch (IllegalAccessException | IllegalArgumentException | InstantiationException | InvocationTargetException xany) {
// it was worth the try
}
}
diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
index b838b08..e8607cf 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
@@ -655,7 +655,6 @@ public final class TemplateEngine extends JxltEngine {
@Override
protected Object evaluate(Interpreter interpreter) {
- final int size = exprs.length;
Object value;
// common case: evaluate all expressions & concatenate them as a string
StringBuilder strb = new StringBuilder();
diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateInterpreter.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateInterpreter.java
index c208927..ebfab0d 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/TemplateInterpreter.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateInterpreter.java
@@ -159,7 +159,6 @@ public class TemplateInterpreter extends Interpreter {
*/
private void printComposite(TemplateEngine.CompositeExpression composite) {
TemplateEngine.TemplateExpression[] cexprs = composite.exprs;
- final int size = cexprs.length;
Object value;
for (TemplateExpression cexpr : cexprs) {
value = cexpr.evaluate(this);