You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/03/23 01:20:15 UTC
Review Request 45184: Added test for mounting host system config
files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45184/
-----------------------------------------------------------
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-3003
https://issues.apache.org/jira/browse/MESOS-3003
Repository: mesos
Description
-------
Added test for mounting host system config files.
Diffs
-----
src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb
Diff: https://reviews.apache.org/r/45184/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh
Thanks,
Gilbert Song
Re: Review Request 45184: Added test for mounting host system config
files.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45184/#review124963
-----------------------------------------------------------
src/tests/containerizer/runtime_isolator_tests.cpp (line 354)
<https://reviews.apache.org/r/45184/#comment187674>
s/'/etc/resolv.conf'/`/etc/resolv.conf`
src/tests/containerizer/runtime_isolator_tests.cpp (lines 354 - 355)
<https://reviews.apache.org/r/45184/#comment187694>
1) Can you please add one more sentense to the comments to clarify that:
We expect the task went to TASK_FINISHED if system config file `/etc/resolv.conf` cab be mounted successfuly to container.
2) s/'alpine'/`alpine`
3) s/'/etc/resolv.conf'/`/etc/resolv.conf`
- Guangya Liu
On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45184/
> -----------------------------------------------------------
>
> (Updated 三月 23, 2016, 12:20 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for mounting host system config files.
>
>
> Diffs
> -----
>
> src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb
>
> Diff: https://reviews.apache.org/r/45184/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 45184: Added test for mounting host system config
files.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45184/
-----------------------------------------------------------
(Updated March 23, 2016, 2:50 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-3003
https://issues.apache.org/jira/browse/MESOS-3003
Repository: mesos
Description
-------
Added test for mounting host system config files.
Diffs (updated)
-----
src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb
Diff: https://reviews.apache.org/r/45184/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh
Thanks,
Gilbert Song