You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2011/09/22 10:39:57 UTC
RE: svn commit: r1173942 - /subversion/trunk/subversion/libsvn_subr/spillbuf.c
> -----Original Message-----
> From: danielsh@apache.org [mailto:danielsh@apache.org]
> Sent: donderdag 22 september 2011 5:04
> To: commits@subversion.apache.org
> Subject: svn commit: r1173942 -
> /subversion/trunk/subversion/libsvn_subr/spillbuf.c
>
> Author: danielsh
> Date: Thu Sep 22 03:03:51 2011
> New Revision: 1173942
>
> URL: http://svn.apache.org/viewvc?rev=1173942&view=rev
> Log:
> Fix some dangling pointers.
s/pointers/comments/ ?
Bert
>
> * subversion/libsvn_subr/spillbuf.c
> (svn_spillbuf__create, svn_spillbuf__reader_create):
> Track double-underscore function renames in comments, too.
>
> Modified:
> subversion/trunk/subversion/libsvn_subr/spillbuf.c
>
> Modified: subversion/trunk/subversion/libsvn_subr/spillbuf.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/spil
> lbuf.c?rev=1173942&r1=1173941&r2=1173942&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_subr/spillbuf.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/spillbuf.c Thu Sep 22 03:03:51
> 2011
> @@ -106,7 +106,7 @@ svn_spillbuf__create(apr_size_t blocksiz
> buf->pool = result_pool;
> buf->blocksize = blocksize;
> buf->maxsize = maxsize;
> - /* Note: changes here should also go into svn_spillbuf_reader_create() */
> + /* Note: changes here should also go into svn_spillbuf__reader_create()
> */
>
> return buf;
> }
> @@ -435,7 +435,7 @@ svn_spillbuf__reader_create(apr_size_t b
> {
> svn_spillbuf_reader_t *sbr = apr_pcalloc(result_pool, sizeof(*sbr));
>
> - /* See svn_spillbuf_create() */
> + /* See svn_spillbuf__create() */
> sbr->buf.pool = result_pool;
> sbr->buf.blocksize = blocksize;
> sbr->buf.maxsize = maxsize;
>
Re: svn commit: r1173942 - /subversion/trunk/subversion/libsvn_subr/spillbuf.c
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Sep 22, 2011 at 04:39, Bert Huijben <be...@qqmail.nl> wrote:
>> -----Original Message-----
>> From: danielsh@apache.org [mailto:danielsh@apache.org]
>> Sent: donderdag 22 september 2011 5:04
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1173942 -
>> /subversion/trunk/subversion/libsvn_subr/spillbuf.c
>>
>> Author: danielsh
>> Date: Thu Sep 22 03:03:51 2011
>> New Revision: 1173942
>>
>> URL: http://svn.apache.org/viewvc?rev=1173942&view=rev
>> Log:
>> Fix some dangling pointers.
>
> s/pointers/comments/ ?
The comments are pointers to elsewhere in the code :-)
Thanks, Daniel.
-g