[jira] [Updated] (HDDS-12725) Remove VisibleForTesting annotations

["Attila Doroszlai (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDDS-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Doroszlai updated HDDS-12725:
------------------------------------
    Target Version/s:   (was: 2.2.0)

> Remove VisibleForTesting annotations
> ------------------------------------
>
>                 Key: HDDS-12725
>                 URL: https://issues.apache.org/jira/browse/HDDS-12725
>             Project: Apache Ozone
>          Issue Type: Task
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>
> I propose to remove {{VisibleForTesting}} annotations.
> - Its javadoc says it should not be used on {{public}} or {{protected}} members, since that indicates bad design.
> - Whether the method is really only used by tests is not validated by any means.  If we start using such a method from non-test code, the annotation is misleading, like outdated javadocs.  There are several examples for that in Ozone, some of them: {{OzoneManager#getKeyManager()}}, {{MutableVolumeSet#getVolumesList()}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org