You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:46:57 UTC

[GitHub] [incubator-echarts] pissang opened a new pull request #13046: [5.0] [FEATURE] Improve default axis style

pissang opened a new pull request #13046:
URL: https://github.com/apache/incubator-echarts/pull/13046


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   
   ### What does this PR do?
   
   This pull request includes optimization of the default axis style. Which includes:
   
   1. Not shown line and tick of `value` axis when another axis is `category` or `time`
   2. Change the color of the line, label, splitLine, splitArea.
   3. Change the color of dataZoom label.
   4. Change the color of axisPointer. Also, change it to dashed line.
   5. Change the color of title subtext.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   ![image](https://user-images.githubusercontent.com/841551/88799097-8e5fb700-d1d8-11ea-9be2-a16bb684872a.png)
   
   ![image](https://user-images.githubusercontent.com/841551/88799135-9881b580-d1d8-11ea-8056-9528f4775951.png)
   
   ![image](https://user-images.githubusercontent.com/841551/88799183-a9cac200-d1d8-11ea-9eae-a61df2a17fb6.png)
   
   ![image](https://user-images.githubusercontent.com/841551/88799251-c23adc80-d1d8-11ea-9122-e68351cfaffc.png)
   
   
   ### After: How is it fixed in this PR?
   
   ![image](https://user-images.githubusercontent.com/841551/88798894-388b0f00-d1d8-11ea-9923-eaa667c7ad26.png)
   
   ![image](https://user-images.githubusercontent.com/841551/88798856-2a3cf300-d1d8-11ea-87f9-7c1e31f77783.png)
   
   ![image](https://user-images.githubusercontent.com/841551/88799005-66705380-d1d8-11ea-8fd0-754b7b3d0ddd.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13046: [5.0] [FEATURE] Improve default axis style

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13046:
URL: https://github.com/apache/incubator-echarts/pull/13046#issuecomment-666047984


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #13046: [5.0] [FEATURE] Improve default axis style

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13046:
URL: https://github.com/apache/incubator-echarts/pull/13046


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13046: [5.0] [FEATURE] Improve default axis style

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13046:
URL: https://github.com/apache/incubator-echarts/pull/13046#issuecomment-665630420


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org