You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "vincentccc (via GitHub)" <gi...@apache.org> on 2023/11/23 02:58:43 UTC
[PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
vincentccc opened a new pull request, #16156:
URL: https://github.com/apache/tvm/pull/16156
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on code in PR #16156:
URL: https://github.com/apache/tvm/pull/16156#discussion_r1408660073
##########
tests/python/dlight/test_primitives.py:
##########
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=missing-docstring
+
+import tvm
+import tvm.testing
+from tvm import relay
+
+
+@tvm.testing.requires_cuda
+def test_normalize_primfunc_with_scalar():
+ relay_text = """
Review Comment:
let us create a test case directly with tvmscript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #16156:
URL: https://github.com/apache/tvm/pull/16156#issuecomment-1823902307
cc @junrushao @vinx13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "vincentccc (via GitHub)" <gi...@apache.org>.
vincentccc closed pull request #16156: [Dlight] Fix NormalizePrimFunc with scalar block
URL: https://github.com/apache/tvm/pull/16156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #16156:
URL: https://github.com/apache/tvm/pull/16156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16156:
URL: https://github.com/apache/tvm/pull/16156#issuecomment-1831123465
thank you @vincentccc can you create a testcase directly with tvmscript without going through relay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Dlight] Fix NormalizePrimFunc with scalar block [tvm]
Posted by "vincentccc (via GitHub)" <gi...@apache.org>.
vincentccc commented on PR #16156:
URL: https://github.com/apache/tvm/pull/16156#issuecomment-1833408425
> thank you @vincentccc can you create a testcase directly with tvmscript without going through relay. It would also be great to simplify this case a bit further
Thanks for your time!
Sure, I will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org