You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2007/05/02 16:24:34 UTC
Re: svn commit: r24884 - trunk/subversion/svn
On Wed, 02 May 2007, malcolm@tigris.org wrote:
...
> When creating svn-commit.tmp, treat the error 'read-only filesystem'
> the same as 'access denied': switch to creating the temporary file in
> the system temporary path instead.
>
> * subversion/svn/util.c
> (svn_cl__edit_externally): Add EROFS to the list of errors to check for.
...
> --- trunk/subversion/svn/util.c (original)
> +++ trunk/subversion/svn/util.c Wed May 2 05:22:25 2007
> @@ -196,7 +196,7 @@
> err = svn_io_open_unique_file2(&tmp_file, &tmpfile_name,
> prefix, ".tmp", svn_io_file_del_none, pool);
>
> - if (err && APR_STATUS_IS_EACCES(err->apr_err))
> + if (err && (APR_STATUS_IS_EACCES(err->apr_err) || err->apr_err == EROFS))
> {
> const char *temp_dir_apr;
Is EROFS defined on all operating systems? If not, we might want to
#ifdef that check.
- Dan
Re: svn commit: r24884 - trunk/subversion/svn
Posted by Lieven Govaerts <sv...@mobsol.be>.
Malcolm Rowe wrote:
> On Wed, May 02, 2007 at 09:24:34AM -0700, Daniel Rall wrote:
>
>>> - if (err && APR_STATUS_IS_EACCES(err->apr_err))
>>> + if (err && (APR_STATUS_IS_EACCES(err->apr_err) || err->apr_err == EROFS))
>>> {
>>> const char *temp_dir_apr;
>>>
>> Is EROFS defined on all operating systems? If not, we might want to
>> #ifdef that check.
>>
>>
>
> It's defined by POSIX, so I hope so (unlike ESTALE, which is a NFS
> invention). It looks like Darwin is happy with it, from the buildbot.
>
> Unfortunately I can't check Windows because there aren't any Windows
> buildbot slaves running at the moment, but I'd say if it works for
> Windows, we're okay.
>
>
Builds fine on Windows (VS.NET 2k5)
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r24884 - trunk/subversion/svn
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Wed, May 02, 2007 at 09:24:34AM -0700, Daniel Rall wrote:
> > - if (err && APR_STATUS_IS_EACCES(err->apr_err))
> > + if (err && (APR_STATUS_IS_EACCES(err->apr_err) || err->apr_err == EROFS))
> > {
> > const char *temp_dir_apr;
>
> Is EROFS defined on all operating systems? If not, we might want to
> #ifdef that check.
>
It's defined by POSIX, so I hope so (unlike ESTALE, which is a NFS
invention). It looks like Darwin is happy with it, from the buildbot.
Unfortunately I can't check Windows because there aren't any Windows
buildbot slaves running at the moment, but I'd say if it works for
Windows, we're okay.
Regards,
Malcolm