[GitHub] [spark] Ngone51 commented on a diff in pull request #39918: [SPARK-42366][SHUFFLE] Log shuffle data corruption diagnose cause

["Ngone51 (via GitHub)" <gi...@apache.org>]

Ngone51 commented on code in PR #39918:
URL: https://github.com/apache/spark/pull/39918#discussion_r1098182999


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/checksum/ShuffleChecksumHelper.java:
##########
@@ -153,6 +152,8 @@ public static Cause diagnoseCorruption(
       logger.warn("Unable to diagnose shuffle block corruption", e);
       cause = Cause.UNKNOWN_ISSUE;
     }
+    logger.info("Shuffle corruption diagnosis took {} ms, checksum file {}, cause {}",
+            duration, checksumFile.getAbsolutePath(), cause);
     return cause;

Review Comment:
   It's up there but the executor logs. So maybe fine to log it too in shuffle service logs. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org