You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/28 15:08:14 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #19860: Restore stability and unquarantine all test_scheduler_job tests

eladkal commented on a change in pull request #19860:
URL: https://github.com/apache/airflow/pull/19860#discussion_r757909993



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -2909,13 +2922,7 @@ def complete_one_dagrun():
         # Pre-condition
         assert DagRun.active_runs_of_dags(session=session) == {'test_dag': 3}
 
-        assert model.next_dagrun == timezone.convert_to_utc(
-            timezone.DateTime(
-                2016,
-                1,
-                3,
-            )
-        )
+        assert model.next_dagrun == timezone.convert_to_utc(timezone.DateTime(2016, 1, 3, tzinfo=UTC))

Review comment:
       Isn't the double convert? `timezone.DateTime(2016, 1, 3, tzinfo=UTC)` should already give UTC the `convert_to_utc` is redundant isn't it?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org