You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/03/07 20:29:05 UTC
[jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
This PR adds the support for the iOS Streaming URI feature to the Cloud Files API.
Changes:
- added iOS URI field to CDNContainerContainerMetadata
- removed legacy "referrer_acl" and "useragent_acl" fields and accessor methods
- updated toString() method
- changed ttl from long to int
- updated parsing of the CDN container name, instead of just using the path:
/v1/MossoCloudFS_187f55c5-8312-48a4-9d85-a18e69bbe9dc/someContainer -> someContainer
To run live tests, go to the "jclouds/apis/cloudfiles" directory and run the following command:
mvn -Plive clean install "-Dtest.cloudfiles.identity=<username>" "-Dtest.cloudfiles.credential=<apiKey>" "-Dtest.cloudfiles.endpoint=https://identity.api.rackspacecloud.com/"
This will also need to be backported to the 1.7.x branch.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds cdn-ios
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/309
-- Commit Summary --
* JCLOUDS-489 - Adds support to Cloud Files for the iOS Streaming URI
-- File Changes --
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/domain/ContainerCDNMetadata.java (74)
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/functions/ParseContainerCDNMetadataFromHeaders.java (33)
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/reference/CloudFilesHeaders.java (3)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/CloudFilesClientExpectTest.java (23)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/CloudFilesClientLiveTest.java (7)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/functions/ParseContainerCDNMetadataListFromJsonResponseTest.java (10)
M apis/cloudfiles/src/test/resources/test_list_cdn.json (11)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/309.patch
https://github.com/jclouds/jclouds/pull/309.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> - URI.create(cdnStreamingUri));
> - }
> + String cdnIosUri = checkNotNull(from.getFirstHeaderOrNull(CloudFilesHeaders.CDN_IOS_URI), CloudFilesHeaders.CDN_IOS_URI);
> +
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
> + checkArgument(!parts.isEmpty(), "incorrect path: " + request.getEndpoint().getPath());
> +
> + return new ContainerCDNMetadata(
> + Iterables.getLast(parts),
> + Boolean.parseBoolean(cdnEnabled),
> + Boolean.parseBoolean(cdnLogRetention),
> + Long.parseLong(cdnTTL),
> + URI.create(cdnUri),
> + URI.create(cdnSslUri),
> + URI.create(cdnStreamingUri),
> + URI.create(cdnIosUri));
This handles the case where any of the latter 4 are `null`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r11187165
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #897](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/897/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37219277
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1132](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1132/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37682945
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
@nacx Thanks for the additional review and I fixed those minor items and squashed/pushed already. ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37678668
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> this.ttl = ttl;
> - this.cdn_uri = cdnUri;
> - this.cdn_ssl_uri = cdnSslUri;
> - this.cdn_streaming_uri = cdnStreamingUri;
> + this.cdnUri = cdnUri;
> + this.cdnSslUri = cdnSslUri;
> + this.cdnStreamingUri = cdnStreamingUri;
> + this.cdnIosUri = cdnIosUri;
Thanks for this property naming cleanup, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10410885
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #642](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/642/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37064729
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> - // CDN is not, and has never, been enabled for this container.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + // just need the name from the path
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
> + checkArgument(parts.size() > 0);
[minor] `!parts.isEmpty()`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10410896
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
@demobox I probably should have named this PR "Update cloudfiles CDN Metadata to support latest service offerings", or something similar. Let me know if that works, thx.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37210256
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Zack Shoylev <no...@github.com>.
merged - good to close
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37684657
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1117](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1117/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37220685
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Zack Shoylev <no...@github.com>.
> @@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
> cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
> final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
> final boolean logRetention = cdnMetadata.isLogRetention();
> - final long initialTTL = cdnMetadata.getTTL();
> + final int initialTTL = cdnMetadata.getTTL();
This shouln't be long everywhere?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10483968
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1112](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1112/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37065129
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> + private URI cdnUri;
> + @Named("cdn_ssl_uri")
> + private URI cdnSslUri;
> + @Named("cdn_streaming_uri")
> + private URI cdnStreamingUri;
> + @Named("cdn_ios_uri")
> + private URI cdnIosUri;
> +
> + @ConstructorProperties({ "name", "cdn_enabled", "log_retention", "ttl", "cdn_uri", "cdn_ssl_uri",
> + "cdn_streaming_uri", "cdn_ios_uri"})
> + public ContainerCDNMetadata(String name, boolean cdnEnabled, boolean logRetention, long ttl,
> + @Nullable URI cdnUri, @Nullable URI cdnSslUri, @Nullable URI cdnStreamingUri, @Nullable URI cdnIosUri) {
> + this.name = checkNotNull(name, "name");
> + this.cdnEnabled = checkNotNull(cdnEnabled);
> + this.logRetention = checkNotNull(logRetention);
> + this.ttl = checkNotNull(ttl);
[minor] Use `checkNotNull(ttl, "ttl")` and similarly above?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r11187126
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1121](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1121/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37336639
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
> - if (cdnUri == null) {
> - // CDN is not, and has never, been enabled for this container.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + // just need the name from the path
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
I agree.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10439923
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
@demobox Do you have any other comments, or can we merge this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37344946
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
> @@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
> cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
> final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
> final boolean logRetention = cdnMetadata.isLogRetention();
> - final long initialTTL = cdnMetadata.getTTL();
> + final int initialTTL = cdnMetadata.getTTL();
An int should be fine for TTL values since the max TTL value is 31536000.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10484484
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #892](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/892/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37063078
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
> }
> -
> +
ack
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10439909
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
> - // CDN is not, and has never, been enabled for this container.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + // just need the name from the path
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
> + checkArgument(parts.size() > 0);
I like your suggestion, so I will update this, thx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10439893
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #651](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/651/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37335611
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Ignasi Barrera <no...@github.com>.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + String cdnIosUri = checkNotNull(from.getFirstHeaderOrNull(CloudFilesHeaders.CDN_IOS_URI), CloudFilesHeaders.CDN_IOS_URI);
> +
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
> + checkArgument(!parts.isEmpty());
Add a message so the `IllegalArgumentException` gives some feedback?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10611222
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Ignasi Barrera <no...@github.com>.
> this.ttl = ttl;
> - this.cdn_uri = cdnUri;
> - this.cdn_ssl_uri = cdnSslUri;
> - this.cdn_streaming_uri = cdnStreamingUri;
> + this.cdnUri = cdnUri;
> + this.cdnSslUri = cdnSslUri;
> + this.cdnStreamingUri = cdnStreamingUri;
> + this.cdnIosUri = cdnIosUri;
Add `checkNotNull` checks or `@Nullable` annotations for nullable properties?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10611129
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
Thanks! @everett-toews
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-39235385
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> - if (cdnUri == null) {
> - // CDN is not, and has never, been enabled for this container.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + // just need the name from the path
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
Keep this as an `Iterable` and use `Iterables.getLast` below?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10410913
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Everett Toews <no...@github.com>.
Closed #309.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1112 UNSTABLE
Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1112/testReport/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37108339
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #915](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/915/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37685701
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Zack Shoylev <no...@github.com>.
Looks good.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37321406
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Zack Shoylev <no...@github.com>.
About to merge.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37680615
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #662](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/662/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37682292
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> removed legacy "referrer_acl" and "useragent_acl" fields and accessor methods
Bit difficult to do know, but this might have been better moved into a separate commit? Or is this required for the iOS support?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37108312
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> }
> -
> +
[minor] remove spaces
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10410887
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #647](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/647/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37219926
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Zack Shoylev <no...@github.com>.
> @@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
> cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
> final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
> final boolean logRetention = cdnMetadata.isLogRetention();
> - final long initialTTL = cdnMetadata.getTTL();
> + final int initialTTL = cdnMetadata.getTTL();
Thanks for the explanation. Do you think a code comment is needed for this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10486073
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Andrew Phillips <no...@github.com>.
> - // CDN is not, and has never, been enabled for this container.
> - return null;
> - }
> - else {
> - return new ContainerCDNMetadata(
> - request.getEndpoint().getPath(),
> - Boolean.parseBoolean(cdnEnabled),
> - Boolean.parseBoolean(cdnLogRetention),
> - Long.parseLong(cdnTTL),
> - URI.create(cdnUri),
> - URI.create(cdnSslUri),
> - URI.create(cdnStreamingUri));
> - }
> + String cdnIosUri = checkNotNull(from.getFirstHeaderOrNull(CloudFilesHeaders.CDN_IOS_URI), CloudFilesHeaders.CDN_IOS_URI);
> +
> + List<String> parts = newArrayList(Splitter.on('/').split(request.getEndpoint().getPath()));
`ImmutableList.copyOf`? Or does it need to be mutable?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r11187155
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Ignasi Barrera <no...@github.com>.
Just a couple minors. LGTM too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37657654
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
As not to disrupt the legacy Cloud Files API signatures, I converted the int back to long for the TTL. The newer implementation uses an int for the [ttl](https://github.com/jclouds/jclouds-labs-openstack/blob/master/rackspace-cloudfiles/src/main/java/org/jclouds/rackspace/cloudfiles/v1/domain/CDNContainer.java#L42).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37329905
Re: [jclouds] JCLOUDS-489 - Adds support to Cloud Files for the iOS
Streaming URI (#309)
Posted by Jeremy Daggett <no...@github.com>.
> this.ttl = ttl;
> - this.cdn_uri = cdnUri;
> - this.cdn_ssl_uri = cdnSslUri;
> - this.cdn_streaming_uri = cdnStreamingUri;
> + this.cdnUri = cdnUri;
> + this.cdnSslUri = cdnSslUri;
> + this.cdnStreamingUri = cdnStreamingUri;
> + this.cdnIosUri = cdnIosUri;
Not a fan of snakey case anyway. ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309/files#r10439898