[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #34335: fix default value for new column as autogenerate SQL was missing default 0

["ephraimbuddy (via GitHub)" <gi...@apache.org>]

ephraimbuddy commented on code in PR #34335:
URL: https://github.com/apache/airflow/pull/34335#discussion_r1324317029


##########
airflow/migrations/versions/0129_2_8_0_add_clear_number_to_dag_run.py:
##########
@@ -43,7 +43,7 @@ def upgrade():
             sa.Column(
                 "clear_number",
                 sa.Integer,
-                default=0,
+                server_default="0",

Review Comment:
   I think we need to handle MSSQL default in the downgrade if we go with server_default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org