[jira] [Commented] (YARN-4435) Add RM Delegation Token DtFetcher Implementation for DtUtil

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357228#comment-15357228 ] 

Steve Loughran commented on YARN-4435:
--------------------------------------

sorry, not looked at the latest version

* I see the URL is being hard coded to HTTP: {{new URL("http://" + url + "/ws/v1/cluster/delegation-token"))}}. Is that going to work? 
* in {{processJSONTransaction}}, could anything be done to improve diagnostics on a failure. If I were to hit a problem here, the first thing I'd want to know is the URL, the second is any text which came back from the HTTP response, rather than just an error code.
* In {{processJSONTransaction}}, should json parse failures just be treated at warn? Or should things fail fast?

I like your tests. But in {{assertEquals() the expected value always comes first —otherwise the generated message is incorrect. Afraid you'll need to swap those args wherever you use that check)

> Add RM Delegation Token DtFetcher Implementation for DtUtil
> -----------------------------------------------------------
>
>                 Key: YARN-4435
>                 URL: https://issues.apache.org/jira/browse/YARN-4435
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Matthew Paduano
>            Assignee: Matthew Paduano
>         Attachments: YARN-4435.00.patch.txt, YARN-4435.01.patch, YARN-4435.02.patch, proposed_solution
>
>
> Add a class to yarn project that implements the DtFetcher interface to return a RM delegation token object.  
> I attached a proposed class implementation that does this, but it cannot be added as a patch until the interface is merged in HADOOP-12563



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org