You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2016/03/02 13:23:09 UTC
[1/4] git commit: [flex-sdk] [refs/heads/develop] - TFC-12136
Removing all the PropertyChangeEvent dispatches which have no value set for
property and oldValue,
and the itemUpdated() calls in collections (which yield the same type of
events) when they co
Repository: flex-sdk
Updated Branches:
refs/heads/develop 244f63300 -> eec643c45
TFC-12136
Removing all the PropertyChangeEvent dispatches which have no value set for property and oldValue, and the itemUpdated() calls in collections (which yield the same type of events) when they come after updates to object's public and bindable properties, because that makes the dispatches superfluous. (The ones I'm leaving in are the ones after updating private properties on objects, so after bypassing the bindable getters and setters, e.g. in AbstractEmployeeTimeAllocationGroupTO; and the ones I don't have time to understand why they're there.)
As a result, IMulticurrencyLineItem does not need to extend IEventDispatcher anymore.
NOTES:
-see the comment in this ticket for why it should be pretty safe to do this.
-also made some minor refactoring where appropriate.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/45e61644
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/45e61644
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/45e61644
Branch: refs/heads/develop
Commit: 45e61644e6a3543937a0fa3db11c3b98b228ae2d
Parents: 244f633
Author: Mihai Chira <mi...@apache.org>
Authored: Wed Mar 2 12:55:30 2016 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Wed Mar 2 12:55:30 2016 +0100
----------------------------------------------------------------------
.../projects/framework/src/mx/collections/ComplexSortField.as | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/45e61644/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
index eb29649..56d6053 100644
--- a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
+++ b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
@@ -20,6 +20,7 @@
package mx.collections {
import mx.utils.ObjectUtil;
+ [Alternative(replacement="spark.collections.ComplexSortField", since="4.15")]
public class ComplexSortField extends SortField implements IComplexSortField
{
private var _nameParts:Array;
[2/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35039
Ignoring failing tests until we decide to work on this bug. Also renamed the
functions to point to the relevant ticket.
Posted by mi...@apache.org.
FLEX-35039
Ignoring failing tests until we decide to work on this bug. Also renamed the functions to point to the relevant ticket.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/951d8d2b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/951d8d2b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/951d8d2b
Branch: refs/heads/develop
Commit: 951d8d2b1cdc9fdcf9e56c6a50ccd0766a8f5bcf
Parents: 45e6164
Author: Mihai Chira <mi...@apache.org>
Authored: Wed Mar 2 13:10:04 2016 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Wed Mar 2 13:10:04 2016 +0100
----------------------------------------------------------------------
.../ArrayCollection_FilterNumbers_Tests.as | 20 ++++++++++----------
.../ArrayCollection_FilterStrings_Tests.as | 18 +++++++++---------
2 files changed, 19 insertions(+), 19 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/951d8d2b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterNumbers_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterNumbers_Tests.as b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterNumbers_Tests.as
index af6d036..5bacfb9 100644
--- a/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterNumbers_Tests.as
+++ b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterNumbers_Tests.as
@@ -40,18 +40,18 @@ package mx.collections {
_sut.addItem(1);
_sut.addItem(2);
}
-
- protected function allIn(object:Object):Boolean
+
+ private static function allIn(object:Object):Boolean
{
return true;
}
-
- protected function allOut(object:Object):Boolean
+
+ private static function allOut(object:Object):Boolean
{
return false;
}
-
- protected function isOne(object:Object):Boolean
+
+ private static function isOne(object:Object):Boolean
{
return object == 1;
}
@@ -200,10 +200,10 @@ package mx.collections {
assertEquals("First element not correct", 1, _sut[0]);
assertEquals("Second element not correct", 1, _sut[1]);
}
-
- //Fails in Apache Flex 4.9.1. See FLEX-35039
- [Test]
- public function swapItemsTwoThenOne():void
+
+ [Ignore]
+ [Test] //See FLEX-35039
+ public function swapItemsTwoThenOne_reproduces_FLEX_35039():void
{
//given
addNumbers();
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/951d8d2b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterStrings_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterStrings_Tests.as b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterStrings_Tests.as
index d82371c..f61d3ec 100644
--- a/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterStrings_Tests.as
+++ b/frameworks/projects/framework/tests/mx/collections/ArrayCollection_FilterStrings_Tests.as
@@ -43,17 +43,17 @@ package mx.collections {
_sut.addItem("C");
}
- protected function allIn(object:Object):Boolean
+ private static function allIn(object:Object):Boolean
{
return true;
}
-
- protected function allOut(object:Object):Boolean
+
+ private static function allOut(object:Object):Boolean
{
return false;
}
-
- protected function isA(object:Object):Boolean
+
+ private static function isA(object:Object):Boolean
{
return object == "A";
}
@@ -218,10 +218,10 @@ package mx.collections {
assertEquals("First element not correct", "A", _sut[0]);
assertEquals("Second element not correct", "A", _sut[1]);
}
-
- //Fails in Apache Flex 4.9.1. See FLEX-35039
- [Test]
- public function swapItemsTwoThenOne():void
+
+ [Ignore]
+ [Test] //See FLEX-35039
+ public function swapItemsTwoThenOne_reproduces_FLEX_35039():void
{
//given
addStrings();
[3/4] git commit: [flex-sdk] [refs/heads/develop] - Revert "TFC-12136"
Posted by mi...@apache.org.
Revert "TFC-12136"
This reverts commit 45e61644e6a3543937a0fa3db11c3b98b228ae2d.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2797a2c3
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2797a2c3
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2797a2c3
Branch: refs/heads/develop
Commit: 2797a2c3233ee08f5345719559e7cb40ee100db2
Parents: 951d8d2
Author: Mihai Chira <mi...@apache.org>
Authored: Wed Mar 2 13:19:01 2016 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Wed Mar 2 13:19:01 2016 +0100
----------------------------------------------------------------------
.../projects/framework/src/mx/collections/ComplexSortField.as | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2797a2c3/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
index 56d6053..eb29649 100644
--- a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
+++ b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
@@ -20,7 +20,6 @@
package mx.collections {
import mx.utils.ObjectUtil;
- [Alternative(replacement="spark.collections.ComplexSortField", since="4.15")]
public class ComplexSortField extends SortField implements IComplexSortField
{
private var _nameParts:Array;
[4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34852
Mentioning that the spark version of ComplexSortField is preferable.
Posted by mi...@apache.org.
FLEX-34852
Mentioning that the spark version of ComplexSortField is preferable.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/eec643c4
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/eec643c4
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/eec643c4
Branch: refs/heads/develop
Commit: eec643c453a3a1bec6ea3352b0c94ec81d36b2d6
Parents: 2797a2c
Author: Mihai Chira <mi...@apache.org>
Authored: Wed Mar 2 13:22:29 2016 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Wed Mar 2 13:22:29 2016 +0100
----------------------------------------------------------------------
.../projects/framework/src/mx/collections/ComplexSortField.as | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/eec643c4/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
index eb29649..f651503 100644
--- a/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
+++ b/frameworks/projects/framework/src/mx/collections/ComplexSortField.as
@@ -20,6 +20,8 @@
package mx.collections {
import mx.utils.ObjectUtil;
+ [Alternative(replacement="spark.collections.ComplexSortField", since="4.15")]
+
public class ComplexSortField extends SortField implements IComplexSortField
{
private var _nameParts:Array;