You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/01/17 13:54:56 UTC

[GitHub] brooklyn-server pull request #522: Class renames for advanced-networking vcl...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/522

    Class renames for advanced-networking vcloud-director

    See https://github.com/brooklyncentral/advanced-networking/pull/116

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server classRenames-advancedNetworking-vcloudDirector

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #522
    
----
commit 830389ca555377eb7fdb7ef742d11c2d9e198040
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-17T13:53:14Z

    Add DeserializingClassRenamesProviderTest

commit 91c602d2a7c95857267d9f7b570d3d2118780050
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-17T13:53:44Z

    classRenames: Add advanced-networking package renames

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #522: Class renames for advanced-networking vcl...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #522: Class renames for advanced-networking vcloud-dir...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/522
  
    Thinking about this more, given that brooklyncentral/advanced-networking is not part of Apache Brooklyn, maybe these renames should not be included in core brooklyn. It could be the responsibility of downstream projects to do this (if they are bundling advanced-networking).
    
    Longer term, if we support multiple properties files that are aggregated, then advanced-networking can supply its own renames file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #522: Class renames for advanced-networking vcloud-dir...

Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva commented on the issue:

    https://github.com/apache/brooklyn-server/pull/522
  
    Looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---