You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/14 17:29:20 UTC
[GitHub] [shardingsphere] captainbkarthick opened a new issue, #21573: Mistake in Template String format.
captainbkarthick opened a new issue, #21573:
URL: https://github.com/apache/shardingsphere/issues/21573
https://github.com/apache/shardingsphere/blob/00f5553fa3b5ba2b772e9fecb58fe72f6ee4119e/agent/api/src/main/java/org/apache/shardingsphere/agent/config/PluginConfiguration.java#L49
The error message template is passed as `"Port %d of %s must be a positive number"`.
But upon tracing the details, I noticed that the arguments passed are converted to string and the values are not set as per the desired object type.
**Possible Solution;**
`Preconditions.checkArgument(port > 0, "Port `%s` of %s must be a positive number", port, type);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #21573: PluginConfiguration: validate() - StringTemplate argument would return erroneous value.
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #21573: PluginConfiguration: validate() - StringTemplate argument would return erroneous value.
URL: https://github.com/apache/shardingsphere/issues/21573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] captainbkarthick commented on issue #21573: PluginConfiguration: validate() - StringTemplate argument would return erroneous value.
Posted by GitBox <gi...@apache.org>.
captainbkarthick commented on issue #21573:
URL: https://github.com/apache/shardingsphere/issues/21573#issuecomment-1282407635
Hi @terrymanu ,
Can you check this and confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] captainbkarthick commented on issue #21573: Mistake in Template String format.
Posted by GitBox <gi...@apache.org>.
captainbkarthick commented on issue #21573:
URL: https://github.com/apache/shardingsphere/issues/21573#issuecomment-1280274496
@terrymanu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] captainbkarthick commented on issue #21573: Mistake in Template String format.
Posted by GitBox <gi...@apache.org>.
captainbkarthick commented on issue #21573:
URL: https://github.com/apache/shardingsphere/issues/21573#issuecomment-1280274004
Could you please check and assign this issue to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] captainbkarthick commented on issue #21573: PluginConfiguration: validate() - StringTemplate argument would return erroneous value.
Posted by GitBox <gi...@apache.org>.
captainbkarthick commented on issue #21573:
URL: https://github.com/apache/shardingsphere/issues/21573#issuecomment-1283441621
@terrymanu/ @strongduanmu
Requesting to check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org