You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/15 16:55:01 UTC

[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4296: CheckstyleV2:Add checkstyle rule to prevent using raw ConcurrentHashMap, LinkedHashSet

RussellSpitzer commented on a change in pull request #4296:
URL: https://github.com/apache/iceberg/pull/4296#discussion_r827206887



##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -56,6 +56,11 @@
         <property name="message"
                   value="Prefer using Maps.newHashMap instead."/>
     </module>
+    <module name="RegexpSingleline">
+        <property name="format" value="new ConcurrentHashMap&lt;&gt;\(.*\)"/>
+        <property name="message"

Review comment:
       This looks good to me but does it need to be two lines? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org