[jira] [Commented] (TIKA-1314) An inappropriate comment of CharsetDetector.detect()

["Tyler Palsulich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372066#comment-14372066 ] 

Tyler Palsulich commented on TIKA-1314:
---------------------------------------

This is still an issue in Tika 1.8-SNAPSHOT. See [here|https://github.com/apache/tika/blob/4096059da7f6d50e3d6e018681b8c02a96d3933a/tika-parsers/src/main/java/org/apache/tika/parser/txt/CharsetDetector.java#L141-L172]. Any input on whether we should update the comment or throw an Exception?

> An inappropriate comment of CharsetDetector.detect()
> ----------------------------------------------------
>
>                 Key: TIKA-1314
>                 URL: https://issues.apache.org/jira/browse/TIKA-1314
>             Project: Tika
>          Issue Type: Bug
>          Components: parser
>    Affects Versions: 1.5
>            Reporter: Yi EungJun
>            Priority: Minor
>
> According to the javadoc of CharsetDetector.detect(), it raises an
> exception if no charset appears to match the data:
>      * Raise an exception if
>      *  <ul>
>      *    <li>no charsets appear to match the input data.</li>
>      *    <li>no input text has been provided</li>
>      *  </ul>
> But it seems to me that in such cases the method returns null but does not raise any exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)