You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2025/09/26 15:25:49 UTC
[PR] Core, Spark, Flink: Remove `org.jetbrains.annotations` [iceberg]
manuzhang opened a new pull request, #14192:
URL: https://github.com/apache/iceberg/pull/14192
When [adding support for Spark 4.1](https://github.com/apache/iceberg/pull/14155), I find imports `org.jetbrains.*` can no longer be resolved. It turns out `org.jetbrains.annotations` dependency is pulled in through ORC, and Spark 4.1 upgraded to [ORC 2.2.0](https://orc.apache.org/news/2025/07/29/ORC-2.2.0/), which changed `org.jetbrains.anntations` to `provided`.
On the other hand, Iceberg explicitly depends on `com.google.code.findbugs:jsr305` so `org.jetbrains.NotNull` and `org.jetbrains.Nullable` can actually be replaced with `javax.annotation.Nonnull` and `javax.annotation.Nullable` respectively. In addition, we use `javax.annotation.*` in more places than `org.jetbrains.*`.
We don't need to explicitly add `org.jetbrains.annotations` dependency for Spark 4.1. Instead, its usage can just be replaced by `com.google.code.findbugs:jsr305`.
This PR excludes `org.jetbrains.annotations` globally, replacing its usages, and removing it from LICENSE files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Spark, Flink: Remove `org.jetbrains.annotations` [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #14192:
URL: https://github.com/apache/iceberg/pull/14192#issuecomment-3346986328
aligning the codebase in terms of these checks makes sense to me, but we might want to eventually consider moving to jspecify for static analysis checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Spark, Flink: Remove `org.jetbrains.annotations` [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #14192:
URL: https://github.com/apache/iceberg/pull/14192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org