You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Jonathan Coveney (JIRA)" <ji...@apache.org> on 2012/10/25 20:03:12 UTC
[jira] [Created] (PIG-3006) Modernize a chunk of the tests
Jonathan Coveney created PIG-3006:
-------------------------------------
Summary: Modernize a chunk of the tests
Key: PIG-3006
URL: https://issues.apache.org/jira/browse/PIG-3006
Project: Pig
Issue Type: Improvement
Reporter: Jonathan Coveney
Assignee: Jonathan Coveney
Fix For: 0.12
Attachments: PIG-3006-0.patch
A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
- get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
- Nothing should extend TestCase. Everything should be annotation driven.
- Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
- Get rid of MiniCluster use in a handful of cases.
I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484431#comment-13484431 ]
Jonathan Coveney commented on PIG-3006:
---------------------------------------
Thanks :) Now I just need to cajole a committer into reviewing it ;)
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-3006:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I ran the full unit test suite with both hadoop 20 and 23 and didn't see any additional failures.
Committed to trunk. Thanks Jonathan!
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-3006:
----------------------------------
Attachment: PIG-3006-1.patch
Thanks for the comments Gianmarco. I cleaned things up even more.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-3006:
-------------------------------
Attachment: PIG-3006-3.patch
I am running the unit test suite with this patch and like to commit this to trunk unless anyone is planning to.
I noticed that the patch already doesn't apply nicely to trunk, so I am attaching a new patch that fixes conflicts. They're all due to white space changes. It should be OK for me to proceed, shouldn't it? Let me know.
{code}
1 out of 7 hunks FAILED -- saving rejects to file test/org/apache/pig/test/TestInputOutputFileValidator.java.rej
1 out of 8 hunks FAILED -- saving rejects to file test/org/apache/pig/test/TestLocal2.java.rej
1 out of 4 hunks FAILED -- saving rejects to file test/org/apache/pig/test/TestNewPlanColumnPrune.java.rej
1 out of 27 hunks FAILED -- saving rejects to file test/org/apache/pig/test/TestStore.java.rej
8 out of 21 hunks FAILED -- saving rejects to file test/org/apache/pig/test/TestStreamingLocal.java.rej
{code}
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492182#comment-13492182 ]
Jonathan Coveney commented on PIG-3006:
---------------------------------------
Awesome! Thanks, Cheolsoo. Now onto https://issues.apache.org/jira/browse/PIG-3016 :D
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch, PIG-3006-4.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-3006:
-------------------------------
Attachment: PIG-3006-4.patch
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch, PIG-3006-4.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484437#comment-13484437 ]
Gianmarco De Francisci Morales commented on PIG-3006:
-----------------------------------------------------
I did a quick review and it looked good (I left a couple of comments), but I would feel better if one more committer reviews it.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485355#comment-13485355 ]
Gianmarco De Francisci Morales commented on PIG-3006:
-----------------------------------------------------
I am fine with the changes, but it's a huge patch so I skimmed through it, I might have missed something.
+0, let's wait for another pair of eyeballs.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491487#comment-13491487 ]
Alan Gates commented on PIG-3006:
---------------------------------
+1 from another pair of eyeballs. :)
Thanks for taking on this important but tedious work.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-3006:
----------------------------------
Attachment: PIG-3006-2.patch
This patch takes into account Cheolsoo's RB comments. It ALSO includes whitespace changes. We will see how that goes!
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492477#comment-13492477 ]
Gianmarco De Francisci Morales commented on PIG-3006:
-----------------------------------------------------
Great job guys!
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch, PIG-3006-4.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484325#comment-13484325 ]
Jonathan Coveney commented on PIG-3006:
---------------------------------------
Here is the RB: https://reviews.apache.org/r/7734/
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485684#comment-13485684 ]
Jonathan Coveney commented on PIG-3006:
---------------------------------------
Cheolsoo, I saw your comments in the RB, and they are good. Specially w.r.t whitespace, I was hoping you could express similar sentiment here: https://issues.apache.org/jira/browse/PIG-3008 The whitespace issue is of particular annoyance to me and I'd love to come up with a solution.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491747#comment-13491747 ]
Jonathan Coveney commented on PIG-3006:
---------------------------------------
Cheolsoo,
Absolutely feel free to proceed as such. It doesn't apply completely afaik b/c a lot of the windows patches clashed (Daniel alerted me to this but I said for them to go ahead and that we would fix it). So go ahead and fix and we're good to go.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484424#comment-13484424 ]
Gianmarco De Francisci Morales commented on PIG-3006:
-----------------------------------------------------
Great job Jon! Our test suite definitely needed some cleanup.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-3006:
----------------------------------
Status: Patch Available (was: Open)
I've attached a patch and will attach an RB.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3006) Modernize a chunk of the tests
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-3006:
----------------------------------
Attachment: PIG-3006-0.patch
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira