general/5866: ap_connect does not return a value in one error case

[Allen Prescott <al...@clanprescott.com>]

>Number:         5866
>Category:       general
>Synopsis:       ap_connect does not return a value in one error case
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Sun Mar 12 21:20:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     allen@clanprescott.com
>Release:        2.0a1
>Organization:
apache
>Environment:
Win32 VC++ 6.0 sp3
>Description:
If the connect call fails in ap_connect and the failure is not WSAEWOULDBLOCK then no value is returned from the function.
>How-To-Repeat:
VC6 compiler points this out. Look at line 230 of apr/network_io/win32/sockets.c.
>Fix:
Write a function that maps the winsock errors onto the APR errors and call it to return an appropriate value.
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]