You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "arjun4084346 (via GitHub)" <gi...@apache.org> on 2023/04/11 16:50:37 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request, #3671: DRAFT
arjun4084346 opened a new pull request, #3671:
URL: https://github.com/apache/gobblin/pull/3671
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3671: [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3671:
URL: https://github.com/apache/gobblin/pull/3671#issuecomment-1506180191
## [Codecov](https://codecov.io/gh/apache/gobblin/pull/3671?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3671](https://codecov.io/gh/apache/gobblin/pull/3671?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9889c1) into [master](https://codecov.io/gh/apache/gobblin/commit/234067109f63860da062fdbb8755c9afc6add9c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2340671) will **increase** coverage by `2.48%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3671 +/- ##
============================================
+ Coverage 46.89% 49.37% +2.48%
+ Complexity 10772 9291 -1481
============================================
Files 2141 1759 -382
Lines 84093 68445 -15648
Branches 9350 7803 -1547
============================================
- Hits 39437 33798 -5639
+ Misses 41058 31505 -9553
+ Partials 3598 3142 -456
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `85.71% <ø> (ø)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `25.70% <100.00%> (+0.30%)` | :arrow_up: |
... and [388 files with indirect coverage changes](https://codecov.io/gh/apache/gobblin/pull/3671/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley commented on a diff in pull request #3671: [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes
Posted by "jack-moseley (via GitHub)" <gi...@apache.org>.
jack-moseley commented on code in PR #3671:
URL: https://github.com/apache/gobblin/pull/3671#discussion_r1164677557
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -331,6 +323,17 @@ public GobblinYarnAppLauncher(Config config, YarnConfiguration yarnConfiguration
}
}
+ protected void createPotentonYarnClients(Config config, Map<String, YarnClient> potentialYarnClients) {
Review Comment:
Did you mean to name this `createPotentialYarnClients`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3671: [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3671:
URL: https://github.com/apache/gobblin/pull/3671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 commented on a diff in pull request #3671: [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #3671:
URL: https://github.com/apache/gobblin/pull/3671#discussion_r1164805505
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -331,6 +323,17 @@ public GobblinYarnAppLauncher(Config config, YarnConfiguration yarnConfiguration
}
}
+ protected void createPotentonYarnClients(Config config, Map<String, YarnClient> potentialYarnClients) {
Review Comment:
Oh yes, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org