You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/01/25 15:40:20 UTC

[GitHub] mlaz commented on a change in pull request #763: [WIP - Do not merge] Integrate nrfx

mlaz commented on a change in pull request #763: [WIP - Do not merge] Integrate nrfx
URL: https://github.com/apache/mynewt-core/pull/763#discussion_r163879290
 
 

 ##########
 File path: apps/soft_pwm_test/pkg.yml
 ##########
 @@ -26,9 +26,6 @@ pkg.keywords:
 
 pkg.deps:
     - kernel/os
-   # - hw/hal
-   # - hw/cmsis-core
     - sys/console/full
-   # - hw/bsp/nrf52dk
 
 Review comment:
   These comments are the kind of thing I usually address when cleaning up.
   I am actually considering to delete this app. We may simply have pwm_test using any pwm driver, by just enabling whatever driver the user wants with newt setting a given syscfg variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services