[GitHub] [flink] zjuwangg commented on a change in pull request #16599: [FLINK-23479][table-planner] Fix the unstable test cases about json plan

[GitBox <gi...@apache.org>]

zjuwangg commented on a change in pull request #16599:
URL: https://github.com/apache/flink/pull/16599#discussion_r678127187



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/LogicalTypeJsonDeserializer.java
##########
@@ -130,6 +139,11 @@ public LogicalType deserialize(JsonNode logicalTypeNode, SerdeContext serdeCtx)
                     return deserializeArrayType(logicalTypeNode, serdeCtx);
                 case MULTISET:
                     return deserializeMultisetType(logicalTypeNode, serdeCtx);
+                case RAW:
+                    // This method only deserializes the LogicalType with `type='RAW'`,

Review comment:
       Nit. Code comment here seems useless since in `deserializeRawType` there is no fallback logic, maybe we can delete it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org