[jira] [Assigned] (MESOS-4093) Unify namespace order in mesos code

["Yong Tang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yong Tang reassigned MESOS-4093:
--------------------------------

    Assignee: Yong Tang

> Unify namespace order in mesos code
> -----------------------------------
>
>                 Key: MESOS-4093
>                 URL: https://issues.apache.org/jira/browse/MESOS-4093
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Assignee: Yong Tang
>
> This is from code review for https://reviews.apache.org/r/40995/
> There is no rule for where to put std namespace.
> Style 1)
> {code}
> using process::Clock;
> using process::Future;
> using process::Message;
> using process::PID;
> using std::vector;
> {code}
> Style 2)
> {code}
> using std::string;
> using std::vector;
> using google::protobuf::RepeatedPtrField;
> using mesos::internal::master::Master;
> using mesos::internal::slave::Slave;
> using mesos::quota::QuotaInfo;
> using process::Future;
> using process::PID;
> using process::http::BadRequest;
> using process::http::Conflict;
> using process::http::OK;
> using process::http::Response;
> {code}
> I think that we should always follow style 2) to make sure putting std at the beginning as it is system library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)