You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "onobc (via GitHub)" <gi...@apache.org> on 2024/02/16 21:38:37 UTC
[PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
onobc opened a new pull request, #22063:
URL: https://github.com/apache/pulsar/pull/22063
This commit introduces a Github Actions workflow that runs a Trivy container scan on the following Docker containers:
- apachepulsar/pulsar:3.2.0
- apachepulsar/pulsar-all:3.2.0
The workflow runs daily @ 0800 UTC and if it finds any vulnerabilities of HIGH or CRITICAL severity it sends an email including the report to the Pulsar DEV mailing list as well as upload the report to the workflow run in Github.
### Motivation
Our dependencies are currently scanned via the OWASP dependency checker but we have nothing checking on the vulnerability of our published Docker containers.
### Modifications
As described in the summary, this adds a scheduled workflow that uses [Trivy](https://trivy.dev/) to run a scan against our published Docker containers.
### Verifying this change
As always, Github Actions workflow are a pain to test. I have tested this one in isolation in prototype repository and it works well. We will not be able to verify it until it gets merged into mainline branch.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/onobc/pulsar/pull/4
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493017367
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
Review Comment:
I chose `table` as the default option for human readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#issuecomment-2025594055
The workflow has been simplified - PTAL @merlimat @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493010760
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
+ uses: aquasecurity/trivy-action@master
+ with:
+ image-ref: ${{ env.IMAGE_REF }}
+ scanners: vuln
+ severity: ${{ inputs.severity != 'ALL' && inputs.severity || 'UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL' }}
+ limit-severities-for-sarif: true
+ format: ${{ inputs.report-format }}
+ output: ${{ steps.prepare-vars.outputs.report_filename }}
+ exit-code: 1
+ - name: Email Trivy container scan report
+ uses: dawidd6/action-send-mail@v3
+ if: ${{ failure() }}
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{secrets.TRIVY_SCAN_MAIL_USERNAME}}
Review Comment:
These 2 secrets are needed for this to work. When testing in my personal Github repo I used my personal gmail account and an application token as recommended by [the send mail plugin](https://github.com/dawidd6/action-send-mail?tab=readme-ov-file#gmail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1507133706
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
+ uses: aquasecurity/trivy-action@master
+ with:
+ image-ref: ${{ env.IMAGE_REF }}
+ scanners: vuln
+ severity: ${{ inputs.severity != 'ALL' && inputs.severity || 'UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL' }}
+ limit-severities-for-sarif: true
+ format: ${{ inputs.report-format }}
+ output: ${{ steps.prepare-vars.outputs.report_filename }}
+ exit-code: 1
+ - name: Email Trivy container scan report
+ uses: dawidd6/action-send-mail@v3
+ if: ${{ failure() }}
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{secrets.TRIVY_SCAN_MAIL_USERNAME}}
+ password: ${{secrets.TRIVY_SCAN_MAIL_PASSWORD}}
+ subject: Trivy container scan results for ${{ env.IMAGE_REF }}
+ to: dev@pulsar.apache.org
+ from: Github Trivy Container Scanner
+ body: Trivy reported vulnerabilities (${{ inputs.severity }}) for ${{ env.IMAGE_REF }}
+ ignore_cert: true
+ attachments: '${{ github.workspace }}/${{ steps.prepare-vars.outputs.report_filename }}'
+ - name: Upload Trivy container scan report
+ uses: actions/upload-artifact@v4
+ if: ${{ failure() }}
+ with:
+ name: trivy-vuln-report-${{ steps.prepare-vars.outputs.image_ref_clean }}
+ path: '${{ github.workspace }}/${{ steps.prepare-vars.outputs.report_filename }}'
+ retention-days: 15
Review Comment:
I think we can remove that. If we can see the alerts in the "Security" tab, it would be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493014302
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
Review Comment:
My intention was to move this to a script but due to time constraints I went w/ this GH actions directly. We can easily move this to the command line so we could invoke outside of GHA as well. The command that this action ultimately uses looks as simple as:
> trivy image --exit-code 1 --vuln-type os,library --scanners vuln --severity HIGH,CRITICAL --output trivy-scan-apachepulsar_pulsar_3_2_0. apachepulsar/pulsar:3.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1506920558
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
+ uses: aquasecurity/trivy-action@master
+ with:
+ image-ref: ${{ env.IMAGE_REF }}
+ scanners: vuln
+ severity: ${{ inputs.severity != 'ALL' && inputs.severity || 'UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL' }}
+ limit-severities-for-sarif: true
+ format: ${{ inputs.report-format }}
+ output: ${{ steps.prepare-vars.outputs.report_filename }}
+ exit-code: 1
+ - name: Email Trivy container scan report
+ uses: dawidd6/action-send-mail@v3
+ if: ${{ failure() }}
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{secrets.TRIVY_SCAN_MAIL_USERNAME}}
+ password: ${{secrets.TRIVY_SCAN_MAIL_PASSWORD}}
+ subject: Trivy container scan results for ${{ env.IMAGE_REF }}
+ to: dev@pulsar.apache.org
+ from: Github Trivy Container Scanner
+ body: Trivy reported vulnerabilities (${{ inputs.severity }}) for ${{ env.IMAGE_REF }}
+ ignore_cert: true
+ attachments: '${{ github.workspace }}/${{ steps.prepare-vars.outputs.report_filename }}'
+ - name: Upload Trivy container scan report
+ uses: actions/upload-artifact@v4
+ if: ${{ failure() }}
+ with:
+ name: trivy-vuln-report-${{ steps.prepare-vars.outputs.image_ref_clean }}
+ path: '${{ github.workspace }}/${{ steps.prepare-vars.outputs.report_filename }}'
+ retention-days: 15
Review Comment:
@merlimat I added a step at the end that will upload to GH when the report format type is `sarif`.
Should we remove the `upload-artifact` step altogether **OR** only call it when the report format is not `sarif`?
Should we ditch the ability to specify different report formats and just go w/ `sarif`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493011353
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
+ uses: aquasecurity/trivy-action@master
+ with:
+ image-ref: ${{ env.IMAGE_REF }}
+ scanners: vuln
+ severity: ${{ inputs.severity != 'ALL' && inputs.severity || 'UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL' }}
+ limit-severities-for-sarif: true
+ format: ${{ inputs.report-format }}
+ output: ${{ steps.prepare-vars.outputs.report_filename }}
+ exit-code: 1
+ - name: Email Trivy container scan report
+ uses: dawidd6/action-send-mail@v3
+ if: ${{ failure() }}
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{secrets.TRIVY_SCAN_MAIL_USERNAME}}
Review Comment:
Do we have another mail server that we use for things of this nature? If so, we could configure it in accordingly. If not, I am more than happy to use my personal email w/ the app token until we get it figured out. Just lmk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493011687
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
Review Comment:
I just took a stab at this point in time. If there is something that makes more sense we can adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1543253362
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,67 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.1'
Review Comment:
Maybe we should have `latest` here. Unfortunately, we don't have a `nightly` tag to test the image from master branch.
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,67 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
Review Comment:
`pulsar-all` should get dropped in 3.3, so we can already drop it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #22063:
URL: https://github.com/apache/pulsar/pull/22063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1493012050
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
Review Comment:
If we add `MEDIUM` we get litup w/ 36 vulnerabilities. What level do we want to filter by?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat][ci] Add Trivy container scan Github workflow [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #22063:
URL: https://github.com/apache/pulsar/pull/22063#discussion_r1507449184
##########
.github/workflows/ci-trivy-container-scan.yaml:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - Trivy Container Scan
+on:
+ schedule:
+ - cron: '0 8 * * *' # Every day at 8am UTC
+ workflow_dispatch:
+ inputs:
+ report-format:
+ description: 'Format of the report'
+ type: choice
+ default: table
+ options:
+ - table
+ - json
+ - sarif
+ severity:
+ description: "Severities to include (comma-separated or 'ALL' to include all)"
+ required: false
+ default: 'CRITICAL,HIGH'
+
+jobs:
+ container_scan:
+ if: ${{ github.repository == 'apache/pulsar' }}
+ name: Trivy Docker image vulnerability scan
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ docker-image:
+ - 'apachepulsar/pulsar'
+ - 'apachepulsar/pulsar-all'
+ docker-tag:
+ - '3.2.0'
+ env:
+ IMAGE_REF: '${{ matrix.docker-image }}:${{ matrix.docker-tag }}'
+ steps:
+ - id: prepare-vars
+ shell: bash
+ run: |
+ IMAGE_REF_CLEAN="$(echo $IMAGE_REF | sed 's/-/_/g; s/\./_/g; s/:/_/g; s/\//_/g')"
+ echo "image_ref_clean=$IMAGE_REF_CLEAN" >> "$GITHUB_OUTPUT"
+ echo "report_filename=trivy-scan-$IMAGE_REF_CLEAN.${{ inputs.report-format }}" >> "$GITHUB_OUTPUT"
+ - name: Run Trivy container scan
+ uses: aquasecurity/trivy-action@master
+ with:
+ image-ref: ${{ env.IMAGE_REF }}
+ scanners: vuln
+ severity: ${{ inputs.severity != 'ALL' && inputs.severity || 'UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL' }}
+ limit-severities-for-sarif: true
+ format: ${{ inputs.report-format }}
+ output: ${{ steps.prepare-vars.outputs.report_filename }}
+ exit-code: 1
+ - name: Email Trivy container scan report
+ uses: dawidd6/action-send-mail@v3
+ if: ${{ failure() }}
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{secrets.TRIVY_SCAN_MAIL_USERNAME}}
Review Comment:
we cannot add secrets to `apache/pulsar` ourselves. The only way to add secrets is to contact ASF Infra support by creating an INFRA ticket in ASF Jira. They will most likely refuse to add a personal token. I'm not sure if there's an email option available. ASF Infra people could be also reached on [ASF Slack's #asfinfra channel](https://infra.apache.org/slack.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org