You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/15 18:26:38 UTC

Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64655/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Greg Mann.


Repository: mesos


Description
-------

Updated upgrades.md about the GET_CONTAINERS API change.


Diffs
-----

  docs/upgrades.md 0c0b7d5623074733e185612e6f11779a5b17fb0e 


Diff: https://reviews.apache.org/r/64655/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64655/#review193955
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64628', '64638', '64639', '64653', '64654', '64655']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64655

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64655/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2497 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2521 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2376 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2401 ms total)

[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (312307 ms total)
[  PASSED  ] 825 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending

10 FAILED TESTS
  YOU HAVE 213 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64655/logs/mesos-tests-stderr.log):

```
I1215 19:20:23.621690   612 master.cpp:10158] Updating the state of task a492ff27-c270-43f4-ab5d-5adf3402d380 of framework f4a2004c-f72e-4a93-a106-4f81701e5b54-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 19:20:23.621690  8796 slave.cpp:3401] Shutting down framework f4a2004c-f72e-4a93I1215 19:20:22.937747  7948 exec.cpp:162] Version: 1.5.0
I1215 19:20:22.960743  1912 exec.cpp:237] Executor registered on agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0
I1215 19:20:22.963749  5460 executor.cpp:171] Received SUBSCRIBED event
I1215 19:20:22.967746  5460 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 19:20:22.967746  5460 executor.cpp:171] Received LAUNCH event
I1215 19:20:22.972748  5460 executor.cpp:638] Starting task a492ff27-c270-43f4-ab5d-5adf3402d380
I1215 19:20:23.054740  5460 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 19:20:23.594683  5460 executor.cpp:651] Forked command at 6056
I1215 19:20:23.623682  9892 exec.cpp:435] Executor asked to shutdown
I1215 19:20:23.624682  5460 executor.cpp:171] Received SHUTDOWN event
I1215 19:20:23.624682  5460 executor.cpp:748] Shutting down
I1215 19:20:23.625682  5460 executor.cpp:855] Sending SIGTERM to process tree at pid 6-a106-4f81701e5b54-0000
I1215 19:20:23.621690  8796 slave.cpp:6109] Shutting down executor 'a492ff27-c270-43f4-ab5d-5adf3402d380' of framework f4a2004c-f72e-4a93-a106-4f81701e5b54-0000 at executor(1)@10.3.1.11:54496
I1215 19:20:23.622683  8796 slave.cpp:909] Agent terminating
W1215 19:20:23.622683  8796 slave.cpp:3397] Ignoring shutdown framework f4a2004c-f72e-4a93-a106-4f81701e5b54-0000 because it is terminating
I1215 19:20:23.623682   612 master.cpp:10264] Removing task a492ff27-c270-43f4-ab5d-5adf3402d380 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f4a2004c-f72e-4a93-a106-4f81701e5b54-0000 on agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0 at slave(327)@10.3.1.11:54475 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 19:20:23.625682  3084 containerizer.cpp:2352] Destroying container e9fd6e8d-91e8-49cf-b50e-1264acd00be1 in RUNNING state
I1215 19:20:23.626682  3084 containerizer.cpp:2955] Transitioning the state of container e9fd6e8d-91e8-49cf-b50e-1264acd00be1 from RUNNING to DESTROYING
I1215 19:20:23.626682   612 master.cpp:1305] Agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0 at slave(327)@10.3.1.11:54475 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 19:20:23.626682   612 master.cpp:3364] Disconnecting agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0 at slave(327)@10.3.1.11:54475 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 19:20:23.626682   612 master.cpp:3383] Deactivating agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0 at slave(327)@10.3.1.11:54475 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 19:20:23.626682  8796 hierarchical.cpp:344] Removed framework f4a2004c-f72e-4a93-a106-4f81701e5b54-0000
I1215 19:20:23.627682  8796 hierarchical.cpp:766] Agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0 deactivated
I1215 19:20:23.627682  3084 launcher.cpp:156] Asked to destroy container e9fd6e8d-91e8-49cf-b50e-1264acd00be1
I1215 19:20:23.703796   612 containerizer.cpp:2803] Container e9fd6e8d-91e8-49cf-b50e-1264acd00be1 has exited
I1215 19:20:23.734045  3816 master.cpp:1147] Master terminating
I1215 19:20:23.736019  2152 hierarchical.cpp:609] Removed agent f4a2004c-f72e-4a93-a106-4f81701e5b54-S0
I1215 19:20:24.034303  4844 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 15, 2017, 6:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64655/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 6:26 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated upgrades.md about the GET_CONTAINERS API change.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 0c0b7d5623074733e185612e6f11779a5b17fb0e 
> 
> 
> Diff: https://reviews.apache.org/r/64655/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64655/#review193985
-----------------------------------------------------------


Fix it, then Ship it!





docs/upgrades.md
Lines 392 (patched)
<https://reviews.apache.org/r/64655/#comment272677>

    Looks like the '#' is unnecessary?



docs/upgrades.md
Lines 394 (patched)
<https://reviews.apache.org/r/64655/#comment272678>

    s/API/API call/


- Greg Mann


On Dec. 15, 2017, 6:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64655/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 6:26 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated upgrades.md about the GET_CONTAINERS API change.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 0c0b7d5623074733e185612e6f11779a5b17fb0e 
> 
> 
> Diff: https://reviews.apache.org/r/64655/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>