You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by NiharS <gi...@git.apache.org> on 2018/07/13 22:18:28 UTC

[GitHub] spark pull request #21765: [MINOR][CORE] Add test cases for RDD.cartesian

GitHub user NiharS opened a pull request:

    https://github.com/apache/spark/pull/21765

    [MINOR][CORE] Add test cases for RDD.cartesian

    ## What changes were proposed in this pull request?
    
    While looking through the codebase, it appeared that the scala code for RDD.cartesian does not have any tests for correctness. This adds a couple basic tests to verify cartesian yields correct values. While the implementation for RDD.cartesian is pretty simple, it always helps to have a few tests!
    
    ## How was this patch tested?
    
    The new test cases pass, and the scala style tests from running dev/run-tests all pass.
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NiharS/spark cartesianTests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21765
    
----
commit 9df4c3b4a71082181aa979c3bddf2c3d99db256e
Author: Nihar Sheth <ni...@...>
Date:   2018-07-13T20:37:59Z

    [MINOR][CORE] Add test cases for RDD.cartesian
    
    The scala code for RDD.cartesian does not have any tests for correctness. This adds a couple basic tests to verify cartesian yields correct values.
    
    Passes the added test cases, and passes the scala style tests.
    
    Author: Nihar Sheth <ni...@gmail.com>

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4218/testReport)** for PR 21765 at commit [`e5f469a`](https://github.com/apache/spark/commit/e5f469a0b83d35b8735eeba30dfca4fe0320810b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4213/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).
     * This patch **fails Spark unit tests**.
     * This patch **does not merge cleanly**.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by NiharS <gi...@git.apache.org>.

Github user NiharS commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    Rebased onto SPARK-24813 so hopefully tests will work now


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4216/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4217 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4217/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4217/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4216 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4216/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    **[Test build #4213 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4213/testReport)** for PR 21765 at commit [`9df4c3b`](https://github.com/apache/spark/commit/9df4c3b4a71082181aa979c3bddf2c3d99db256e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    Yup it will always apply your PR to master anyway, so would have picked it up in this test run.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21765: [MINOR][CORE] Add test cases for RDD.cartesian

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21765
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org