You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2024/06/28 18:10:00 UTC
[jira] [Commented] (SOLR-17327) Update bats test to remove /solr from solr Urls.
[ https://issues.apache.org/jira/browse/SOLR-17327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860875#comment-17860875 ]
Jason Gerlowski commented on SOLR-17327:
----------------------------------------
git-bisect identified this ticket as likely breaking the BATS integration tests on branch_9x. Or more specifically, breaking the "auth enable/disable lifecycle" test in test_auth.bats.
{code}
$ git bisect good
39fe5098c0a1965b2d076f1d67f0797b8a261b03 is the first bad commit
commit 39fe5098c0a1965b2d076f1d67f0797b8a261b03
Author: Eric Pugh <ep...@opensourceconnections.com>
Date: Fri Jun 14 11:43:09 2024 -0400
remove trailing /solr unless we actually are testing it, since that is old school approach (#2519)
solr/packaging/test/test_auth.bats | 2 +-
solr/packaging/test/test_create_collection.bats | 2 +-
solr/packaging/test/test_example_noprompt.bats | 4 ++--
solr/packaging/test/test_placement_plugin.bats | 4 ++--
solr/packaging/test/test_prometheus.bats | 2 +-
solr/packaging/test/test_ssl.bats | 20 ++++++++++----------
solr/packaging/test/test_start_solr.bats | 12 ++++++------
solr/packaging/test/test_status.bats | 2 +-
8 files changed, 24 insertions(+), 24 deletions(-)
{code}
The failure is caused by the "assert" tool, which times out trying to connect to Solr at the provided URL: "http://localhost:${SOLR_PORT}".
This commit is innocuous on 'main', but causes problems on branch_9x where Solr's "context-root" is customizable and therefore needs to be included in any URLs that get passed around in scripts, SolrJ, etc.
I'm going to revert this commit from branch_9x for now (but leave it on main). Normally I'd want to discuss with [~epugh] before reverting, but he's offline for the next few weeks and I don't want to leave the build broken for that long. Hopefully he'll forgive me the breach of etiquette when he returns.
> Update bats test to remove /solr from solr Urls.
> -------------------------------------------------
>
> Key: SOLR-17327
> URL: https://issues.apache.org/jira/browse/SOLR-17327
> Project: Solr
> Issue Type: Sub-task
> Components: cli
> Reporter: Eric Pugh
> Priority: Minor
> Fix For: 9.7
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For all the bats tests Except where it matters, remove the /solr context path from the various --solr-url's.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org