[GitHub] [maven] rfscholte commented on a diff in pull request #744: [MNG-7360] Fix xml transformation to ensure proper context

[GitBox <gi...@apache.org>]

rfscholte commented on code in PR #744:
URL: https://github.com/apache/maven/pull/744#discussion_r875617018


##########
maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java:
##########
@@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, IOException
                 throw new XmlPullParserException( "already reached end of XML input", this, null );
             }
             int currentEvent = xmlPullParser.nextToken();
-            if ( accept() )
+            if ( disabled || accept() )

Review Comment:
   This looks like to conflicting states, which makes me wonder if we can always return currentEvent.
   If current expression is required, we need to think of better naming.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org