You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2014/07/15 21:00:44 UTC
[VOTE] Release Commons CSV based on RC2
Hi all,
We had quite a few findings during the vote on CVS 1.0 RC1. I've worked
through all the issues and fixed most of them. Now I'd like to release CSV
1.0 based on RC2.
Changes since RC1 are:
- CSV now requires Java 7 and the Java requirements are documented in the
release notes and on the website.
- corrected JavaDoc in CSVFormat that was pointing to missing method
parseFile (the JavaDoc now correctly points to the static methods defined
in CSVParser)
- The JavaDoc for the predefined formats in CSVFormat doesn't use h3
sections any more, since this is not good for readbility
- The JavaDoc for the predefined formats in CSVFormat now uses the actual
characters and not the (not visibile) constants from the Constants class
- getters returning booleans in CSVFormat now follow the convention of
starting with "is" instead of "get"
- consistently renamed boolean getters
- Clarified JavaDoc of CSVFormat.withRecordSeparator()
- Renamed CSVFormat.withCommentStart and getCommentStart to
with/getCommentMarker to avoid confusion w.r.t. comment stop
- Clarified JavaDoc of CSVPrinter.printRecord(s) methods
- Clarified in JavaDoc, that CSVPrinter.printRecord also calls
CSVPrinter.println()
- Clarified toString format of CSVPrinter
- Clarified the difference between the current line number of the parser
and the record number of the record
- Removed needless method getRecord(T extends Collection)
- use 4 spaces indentation in user guide
CSV 1.0 RC2 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/csv/ (svn rev. 5862)
(note that CSV can be build using Java 8.0, but the website cannot, since
the maven-findbugs-plugin is still uncompatible with Java 8.0)
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1040/
Details of changes since we started with 1.0 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/csv/RELEASE-NOTES.txt
http://people.apache.org/~britter/csv-1.0-RC2/changes-report.html
The tag is here:
https://svn.apache.org/repos/asf/commons/proper/csv/tags/CSV_1.0_RC2 (svn
rev. 1610788)
N.B. the SVN revision is required because SVN tags are not immutable.
Site:
http://people.apache.org/~britter/csv-1.0-RC2/
(note some *relative* links are broken and the 1.0 directories are
not yet created - these will be OK once the site is deployed)
Clirr Report:
-- No Clirr report, since this is the first release --
RAT Report:
http://people.apache.org/~britter/csv-1.0-RC2/rat-report.html
(note that the files in src/test/resources are ignored by rat, since they
are used as test csv input and test result specifications)
KEYS:
http://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now, i.e. after 2100
GMT 18-July 2014
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thanks!
Benedikt
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: [VOTE] Release Commons CSV based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
+1 with:
Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e;
2014-06-17T09:51:42-04:00)
Maven home: C:\Java\apache-maven-3.2.2
Java version: 1.7.0_60, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_60\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
But fails with Java 8 due to some Jacoco problem.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at
sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:386)
at
sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:401)
Caused by: java.lang.RuntimeException: Class java/util/UUID could not be
instrumented.
at
org.jacoco.agent.rt.internal_6effb9e.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:138)
at
org.jacoco.agent.rt.internal_6effb9e.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:99)
at
org.jacoco.agent.rt.internal_6effb9e.PreMain.createRuntime(PreMain.java:55)
at
org.jacoco.agent.rt.internal_6effb9e.PreMain.premain(PreMain.java:47)
... 6 more
Caused by: java.lang.NoSuchFieldException: $jacocoAccess
at java.lang.Class.getField(Class.java:1690)
at
org.jacoco.agent.rt.internal_6effb9e.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:136)
... 9 more
FATAL ERROR in native method: processing of -javaagent failed
Exception in thread "main"
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
This might be solved with the latest from Jacoco, see commons-parent
35-SNAPSHOT.
Gary
On Tue, Jul 15, 2014 at 3:00 PM, Benedikt Ritter <br...@apache.org> wrote:
> Hi all,
>
> We had quite a few findings during the vote on CVS 1.0 RC1. I've worked
> through all the issues and fixed most of them. Now I'd like to release CSV
> 1.0 based on RC2.
>
> Changes since RC1 are:
>
> - CSV now requires Java 7 and the Java requirements are documented in the
> release notes and on the website.
> - corrected JavaDoc in CSVFormat that was pointing to missing method
> parseFile (the JavaDoc now correctly points to the static methods defined
> in CSVParser)
> - The JavaDoc for the predefined formats in CSVFormat doesn't use h3
> sections any more, since this is not good for readbility
> - The JavaDoc for the predefined formats in CSVFormat now uses the actual
> characters and not the (not visibile) constants from the Constants class
> - getters returning booleans in CSVFormat now follow the convention of
> starting with "is" instead of "get"
> - consistently renamed boolean getters
> - Clarified JavaDoc of CSVFormat.withRecordSeparator()
> - Renamed CSVFormat.withCommentStart and getCommentStart to
> with/getCommentMarker to avoid confusion w.r.t. comment stop
> - Clarified JavaDoc of CSVPrinter.printRecord(s) methods
> - Clarified in JavaDoc, that CSVPrinter.printRecord also calls
> CSVPrinter.println()
> - Clarified toString format of CSVPrinter
> - Clarified the difference between the current line number of the parser
> and the record number of the record
> - Removed needless method getRecord(T extends Collection)
> - use 4 spaces indentation in user guide
>
> CSV 1.0 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/ (svn rev. 5862)
> (note that CSV can be build using Java 8.0, but the website cannot, since
> the maven-findbugs-plugin is still uncompatible with Java 8.0)
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1040/
>
> Details of changes since we started with 1.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/csv/RELEASE-NOTES.txt
> http://people.apache.org/~britter/csv-1.0-RC2/changes-report.html
>
> The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/csv/tags/CSV_1.0_RC2
> (svn
> rev. 1610788)
> N.B. the SVN revision is required because SVN tags are not immutable.
>
> Site:
> http://people.apache.org/~britter/csv-1.0-RC2/
> (note some *relative* links are broken and the 1.0 directories are
> not yet created - these will be OK once the site is deployed)
>
> Clirr Report:
> -- No Clirr report, since this is the first release --
>
> RAT Report:
> http://people.apache.org/~britter/csv-1.0-RC2/rat-report.html
> (note that the files in src/test/resources are ignored by rat, since they
> are used as test csv input and test result specifications)
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. after 2100
> GMT 18-July 2014
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release Commons CSV based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
The 1.7 target is not needed. By changing the 1.7 to 1.6, I was able to
build on Java 6 with:
Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e;
2014-06-17T09:51:42-04:00)
Maven home: C:\Java\apache-maven-3.2.2
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_45\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
It's not a deal breaker for me, but based on the few emails flying around I
think it is worth a re-spin, especially since no code changes are needed.
Gary
On Tue, Jul 15, 2014 at 3:00 PM, Benedikt Ritter <br...@apache.org> wrote:
> Hi all,
>
> We had quite a few findings during the vote on CVS 1.0 RC1. I've worked
> through all the issues and fixed most of them. Now I'd like to release CSV
> 1.0 based on RC2.
>
> Changes since RC1 are:
>
> - CSV now requires Java 7 and the Java requirements are documented in the
> release notes and on the website.
> - corrected JavaDoc in CSVFormat that was pointing to missing method
> parseFile (the JavaDoc now correctly points to the static methods defined
> in CSVParser)
> - The JavaDoc for the predefined formats in CSVFormat doesn't use h3
> sections any more, since this is not good for readbility
> - The JavaDoc for the predefined formats in CSVFormat now uses the actual
> characters and not the (not visibile) constants from the Constants class
> - getters returning booleans in CSVFormat now follow the convention of
> starting with "is" instead of "get"
> - consistently renamed boolean getters
> - Clarified JavaDoc of CSVFormat.withRecordSeparator()
> - Renamed CSVFormat.withCommentStart and getCommentStart to
> with/getCommentMarker to avoid confusion w.r.t. comment stop
> - Clarified JavaDoc of CSVPrinter.printRecord(s) methods
> - Clarified in JavaDoc, that CSVPrinter.printRecord also calls
> CSVPrinter.println()
> - Clarified toString format of CSVPrinter
> - Clarified the difference between the current line number of the parser
> and the record number of the record
> - Removed needless method getRecord(T extends Collection)
> - use 4 spaces indentation in user guide
>
> CSV 1.0 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/ (svn rev. 5862)
> (note that CSV can be build using Java 8.0, but the website cannot, since
> the maven-findbugs-plugin is still uncompatible with Java 8.0)
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1040/
>
> Details of changes since we started with 1.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/csv/RELEASE-NOTES.txt
> http://people.apache.org/~britter/csv-1.0-RC2/changes-report.html
>
> The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/csv/tags/CSV_1.0_RC2
> (svn
> rev. 1610788)
> N.B. the SVN revision is required because SVN tags are not immutable.
>
> Site:
> http://people.apache.org/~britter/csv-1.0-RC2/
> (note some *relative* links are broken and the 1.0 directories are
> not yet created - these will be OK once the site is deployed)
>
> Clirr Report:
> -- No Clirr report, since this is the first release --
>
> RAT Report:
> http://people.apache.org/~britter/csv-1.0-RC2/rat-report.html
> (note that the files in src/test/resources are ignored by rat, since they
> are used as test csv input and test result specifications)
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. after 2100
> GMT 18-July 2014
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release Commons CSV based on RC2
Posted by Benedikt Ritter <br...@apache.org>.
CSVParser implicitly implements AutoClosable because it implements Closable
which extends AutoClosable in Java 7.
I assumed we had consensus about switching to Java 7 to enable
try-with-resource when using CSVParser (this was my bad, sorry). As far as
I understand try-with-resource won't work when the source level is changed
back to Java 6, since the information of implemented interfaces is encoded
in the class.
I'm fine with creating RC3, if we can agree on the target Java level. I
have the feeling everybody is okay with Java 6 (and no try-with-resource
support for now).
Regards,
Benedikt
2014-07-17 10:54 GMT+02:00 Jörg Schaible <jo...@swisspost.com>:
> Hi Benedict,
>
> Benedikt Ritter wrote:
>
> > Hi all,
> >
> > We had quite a few findings during the vote on CVS 1.0 RC1. I've worked
> > through all the issues and fixed most of them. Now I'd like to release
> CSV
> > 1.0 based on RC2.
> >
> > Changes since RC1 are:
> >
> > - CSV now requires Java 7 and the Java requirements are documented in the
> > release notes and on the website.
>
>
> And what to do now with CSV-125? Actually RC1 was built fine for all my
> Java
> 6 JDKs. I did not understand why the JDK version was upgraded from 5 to 7
> without real necessity, but I did not interfere, because you are the
> release
> manager. But obviously there's a need for a Java 6 compatible version and
> there is absolutely no technical reason why CVS should be Java 7 compatible
> only. The claim of Emmanuel that CSV uses AutoCloseable is simply not true:
>
> $> find commons-csv-1.0-src -type f -exec grep AutoClose {} +
>
> [snip]
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: [VOTE] Release Commons CSV based on RC2
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 17/07/2014 10:54, Jörg Schaible a écrit :
> The claim of Emmanuel that CSV uses AutoCloseable is simply not true:
>
> $> find commons-csv-1.0-src -type f -exec grep AutoClose {} +
You are right, sorry about that I got confused by the Javadoc of CSVPrinter:
http://people.apache.org/~britter/csv-1.0-RC1/apidocs/org/apache/commons/csv/CSVPrinter.html
It shows CSVPrinter as implementing AutoCloseable, but this is a side
effect of building the Javadoc with Java 7 instead of Java 6. CSVPrinter
implements only Closeable (available in Java 5) which extends
AutoCloseable in Java 7.
Emmanuel bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons CSV based on RC2
Posted by Jörg Schaible <jo...@swisspost.com>.
Hi Benedict,
Benedikt Ritter wrote:
> Hi all,
>
> We had quite a few findings during the vote on CVS 1.0 RC1. I've worked
> through all the issues and fixed most of them. Now I'd like to release CSV
> 1.0 based on RC2.
>
> Changes since RC1 are:
>
> - CSV now requires Java 7 and the Java requirements are documented in the
> release notes and on the website.
And what to do now with CSV-125? Actually RC1 was built fine for all my Java
6 JDKs. I did not understand why the JDK version was upgraded from 5 to 7
without real necessity, but I did not interfere, because you are the release
manager. But obviously there's a need for a Java 6 compatible version and
there is absolutely no technical reason why CVS should be Java 7 compatible
only. The claim of Emmanuel that CSV uses AutoCloseable is simply not true:
$> find commons-csv-1.0-src -type f -exec grep AutoClose {} +
[snip]
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org