You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Eugene Zimichev (Code Review)" <ge...@cloudera.org> on 2019/12/13 17:53:20 UTC
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Eugene Zimichev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14905
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
IMPALA-8547: get_json_object fails to get value for numeric key
Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
---
M be/src/exprs/expr-test.cc
M be/src/util/string-util.cc
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/14905/1
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6665/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 3
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 22:22:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has uploaded a new patch set (#2) to the change originally created by Eugene Zimichev. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
IMPALA-8547: get_json_object fails to get value for numeric key
Allows numeric keys for JSON objects in get_json_object. This patch
makes Impala consistent with Hive and Postgres behavior for
get_json_object.
Queries such as "select get_json_object('{"1": 5}', '$.1');"
would fail before this patch. Now the query will return '5'.
Testing:
* Added tests to expr-test
Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
---
M be/src/exprs/expr-test.cc
M be/src/util/string-util.cc
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/14905/2
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 2
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 2:
@Tim - cleaned up the patch a bit, should be good to review.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 2
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 21:52:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 3:
> This patch LGTM.
>
> Hive supports more general keys because it just split the json path
> by '.' https://github.com/apache/hive/blob/ba0217ff17501fb849d8999e808d37579db7b4f1/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java#L147
> So this is also workable in Hive:
>
> select get_json_object('{"hello world": 5}', '$.hello world');
>
> It can't work in Impala because "hello world" is not a legal
> variable name.
> I think if we want the compatibility with Hive we can create a JIRA
> to refactor the json patch parsing logics.
I filed IMPALA-9993 as a follow up. I think this requires some more thought. That SQL statement is valid in Postgres, but not MySQL. It seems all databases have a slightly different way of handling JSON. The Hive / Impala syntax seems to be some combination of Postgres / MySQL behavior, which is a bit odd.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 3
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 22:47:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
(1 comment)
Thanks for the contribution Euguene!
A few comments:
It would be great if you could include some more information in the commit message. Take a look at https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala for an example of an Impala commit message. The commit message should include information about how to reproduce the issue, how this patch fixes the issue, and how this patch was tested.
For the patch itself, the behavior here seems to be a bit ambiguous between SQL engines. While Hive (and Spark SQL) can execute the query you pasted in the JIRA, the Hive docs (https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF) actually state that:
Extracts json object from a json string based on json path specified, and returns json string of the extracted json object. It will return null if the input json string is invalid. NOTE: The json path can only have the characters [0-9a-z_], i.e., no upper-case or special characters. Also, the keys *cannot start with numbers.* This is due to restrictions on Hive column names.
I checked MySQL as well, and it actually cannot run the query from the JIRA description (JSON_EXTRACT is the equivalent in MySQL). It fails with the error: "Query Error: Error: ER_INVALID_JSON_PATH: Invalid JSON path expression. The error is around character position 3."
However, if you put quotations around the path identifier, it works:
select JSON_EXTRACT('{"1": 5}', '$."1"');
https://stackoverflow.com/questions/49557144/how-to-extract-values-from-a-numeric-keyed-nested-json-field-in-mysql has more info.
Oddly enough, MS SQL Server and Oracle follows the MySQL behavior, but Postgres follows the Hive behavior.
In general, Impala tries to follow MySQL behavior. Given that MS SQL and Oracle follow the MySQL behavior as well, I think Impala should too.
http://gerrit.cloudera.org:8080/#/c/14905/1/be/src/util/string-util.cc
File be/src/util/string-util.cc:
http://gerrit.cloudera.org:8080/#/c/14905/1/be/src/util/string-util.cc@76
PS1, Line 76: FindEndOfIdentifier
need to update the docs of this method in string-util.h. The docs currently say that this method is to find C style identifiers. A C style identifier cannot start with a digit (https://docs.microsoft.com/en-us/cpp/c-language/c-identifiers?view=vs-2019).
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 18:38:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 15 Dec 2019 01:07:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
IMPALA-8547: get_json_object fails to get value for numeric key
Allows numeric keys for JSON objects in get_json_object. This patch
makes Impala consistent with Hive and Postgres behavior for
get_json_object.
Queries such as "select get_json_object('{"1": 5}', '$.1');"
would fail before this patch. Now the query will return '5'.
Testing:
* Added tests to expr-test
Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Reviewed-on: http://gerrit.cloudera.org:8080/14905
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M be/src/util/string-util.cc
M be/src/util/string-util.h
3 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 5
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 4
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 22:29:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
> Sahil, was the conclusion here that we didn't want to do this? Or
> should we jsut try to be compatible with hive?
I think compatibility with Hive is probably fine, especially given there is not a consistent standard for this behavior across the common relational databases.
The TL;DR of the above comment is that most relational databases support this behavior, but most require quotation marks around numeric keys (MySQL, Oracle, MS SQL). However, Hive / Postgres don't. Perhaps there is a good reason to require quotation marks around numeric keys, I'm not sure.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 23:31:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5281/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 18:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
Yeah, I think we should probably be hive compatible here, so we can share views, etc if needed. Maybe we can clean up the patch and get it in?
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2020 20:43:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6326/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 4
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 17:19:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6664/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 2
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 22:13:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5344/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 14 Dec 2019 20:36:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 1:
Sahil, was the conclusion here that we didn't want to do this? Or should we jsut try to be compatible with hive?
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 22:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has uploaded a new patch set (#3) to the change originally created by Eugene Zimichev. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
IMPALA-8547: get_json_object fails to get value for numeric key
Allows numeric keys for JSON objects in get_json_object. This patch
makes Impala consistent with Hive and Postgres behavior for
get_json_object.
Queries such as "select get_json_object('{"1": 5}', '$.1');"
would fail before this patch. Now the query will return '5'.
Testing:
* Added tests to expr-test
Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
---
M be/src/exprs/expr-test.cc
M be/src/util/string-util.cc
M be/src/util/string-util.h
3 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/14905/3
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 3
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 3
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 17:18:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 3: Code-Review+1
This patch LGTM.
Hive supports more general keys because it just split the json path by '.' https://github.com/apache/hive/blob/ba0217ff17501fb849d8999e808d37579db7b4f1/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java#L147
So this is also workable in Hive:
select get_json_object('{"hello world": 5}', '$.hello world');
It can't work in Impala because "hello world" is not a legal variable name.
I think if we want the compatibility with Hive we can create a JIRA to refactor the json patch parsing logics.
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 3
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 00:32:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 )
Change subject: IMPALA-8547: get_json_object fails to get value for numeric key
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df037ccf2c79da0ba86a46df1dd28ab0e9a45f4
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 4
Gerrit-Owner: Eugene Zimichev <un...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 17:19:35 +0000
Gerrit-HasComments: No