You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/21 02:42:09 UTC

[GitHub] [iotdb] ericpai edited a comment on pull request #3605: [IOTDB-1515]Fix binary convertion in LastQueryExecutor

ericpai edited a comment on pull request #3605:
URL: https://github.com/apache/iotdb/pull/3605#issuecomment-883800383


   > some modification of insertRecord is needed I think…
   
   @HTHou Yes, InsertRecord treats the input `TEXT` type data as a `String`, not `byte[]`. But user will be confused if he uses `InsertTablet` API to insert Binary objects and gets unexcepted ones.
   
   Maybe we can indicate that only valid UTF-8 String supported in TEXT type in `InsertRecord()`, and it will support any bytes in the future. It's backward compatible I think. But if we want to support any bytes, the JDBC interface should implement `getBytes()`. I could help to do this.
   
   However this PR is the superset of  UTF-8 string support(I can add another test case for valid utf8 bytes). Do you think it should be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org