[GitHub] [skywalking] horizonzy commented on a change in pull request #5960: fix springmvc reactive api can't collect HTTP statusCode

[GitBox <gi...@apache.org>]

horizonzy commented on a change in pull request #5960:
URL: https://github.com/apache/skywalking/pull/5960#discussion_r537201335



##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -41,6 +52,23 @@ public void beforeMethod(final EnhancedInstance objInst,
                       .put(RESPONSE_KEY_IN_RUNTIME_CONTEXT, new ReactiveResponseHolder(exchange.getResponse()));
         ContextManager.getRuntimeContext()
                       .put(REQUEST_KEY_IN_RUNTIME_CONTEXT, new ReactiveRequestHolder(exchange.getRequest()));
+
+        ContextCarrier carrier = new ContextCarrier();
+        CarrierItem next = carrier.items();
+        HttpHeaders headers = exchange.getRequest().getHeaders();
+        while (next.hasNext()) {
+            next = next.next();
+            List<String> header = headers.get(next.getHeadKey());
+            if (header != null && header.size() > 0) {
+                next.setHeadValue(header.get(0));
+            }
+        }
+
+        AbstractSpan span = ContextManager.createEntrySpan(exchange.getRequest().getURI().getPath(), carrier);

Review comment:
       > If one component goes to async mode, use async API to close span in another thread. Read doc, please.
   
   Maybe delivery the threadlocal when the thread switch can solve this problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org