You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/27 05:22:32 UTC
[GitHub] [hudi] KnightChess opened a new pull request, #5982: [HUDI-4325] fix saprk sql procedure cause ParseException with semicolon
KnightChess opened a new pull request, #5982:
URL: https://github.com/apache/hudi/pull/5982
## What is the purpose of the pull request
fix use `spark.sql("call show_commits(table => 'delete_error_test', limit => 10);").show(false)` with ';' cause parse error
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix spark sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1167249319
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
}, {
"hash" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50af663d37d075090f98876721098e4d7e053dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577)
* ed65b16fc70131ae5fddb0f256fd52ffe99edcd5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix saprk sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1166887093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50af663d37d075090f98876721098e4d7e053dbb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a diff in pull request #5982: [HUDI-4325] fix saprk sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
yanghua commented on code in PR #5982:
URL: https://github.com/apache/hudi/pull/5982#discussion_r907099290
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestCallCommandParser.scala:
##########
@@ -85,6 +85,17 @@ class TestCallCommandParser extends HoodieSparkSqlTestBase {
checkParseExceptionContain("CALL cat.system radish kebab")("mismatched input 'CALL' expecting")
}
+ test("Test Call Produce with semicolon") {
Review Comment:
Can we also add a test case for the old mode (missing `;`) to verify the original still works OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix spark sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1167253311
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
}, {
"hash" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9588",
"triggerID" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50af663d37d075090f98876721098e4d7e053dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577)
* ed65b16fc70131ae5fddb0f256fd52ffe99edcd5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix saprk sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1166889518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50af663d37d075090f98876721098e4d7e053dbb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars merged pull request #5982: [HUDI-4325] fix spark sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars merged PR #5982:
URL: https://github.com/apache/hudi/pull/5982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix spark sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1167716383
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
}, {
"hash" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9588",
"triggerID" : "ed65b16fc70131ae5fddb0f256fd52ffe99edcd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed65b16fc70131ae5fddb0f256fd52ffe99edcd5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5982: [HUDI-4325] fix saprk sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1167185622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50af663d37d075090f98876721098e4d7e053dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577",
"triggerID" : "50af663d37d075090f98876721098e4d7e053dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50af663d37d075090f98876721098e4d7e053dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9577)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #5982: [HUDI-4325] fix spark sql procedure cause ParseException with semicolon
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5982:
URL: https://github.com/apache/hudi/pull/5982#issuecomment-1168162090
@XuQianJin-Stars @yanghua thanks for review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org