[GitHub] [pinot] walterddr commented on a diff in pull request #10683: Return 503 for all interrupted queries. Refactor the query killing code.

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10683:
URL: https://github.com/apache/pinot/pull/10683#discussion_r1186746157


##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -54,7 +54,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesOfStackTracePerFrame) {
   public static final int ACCESS_DENIED_ERROR_CODE = 180;
   public static final int TABLE_DOES_NOT_EXIST_ERROR_CODE = 190;
   public static final int QUERY_EXECUTION_ERROR_CODE = 200;
-  public static final int QUERY_CANCELLATION_ERROR_CODE = 205;
+  public static final int QUERY_CANCELLATION_ERROR_CODE = 503;

Review Comment:
   is it possible to add a unit test say similar to `CombineErrorOperatorsTest`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org